This repository has been archived by the owner on Jun 13, 2024. It is now read-only.
k8s: Fix a bug when manifest file ends with '---' #139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Any kubernetes manifest file ending with '---' will generate an error when applied using 'k8s' module. Although this may not be 'legal' YAML, this is quite frequent, specially on helm's generated manifest files. migrated from ansible/ansible#59160 Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
Codecov Report
@@ Coverage Diff @@
## master #139 +/- ##
==========================================
- Coverage 42.56% 42.41% -0.16%
==========================================
Files 3 3
Lines 545 547 +2
Branches 110 111 +1
==========================================
Hits 232 232
- Misses 270 271 +1
- Partials 43 44 +1
Continue to review full report at Codecov.
|
|
It doesn't have to end in |
|
Thanks @Akasurde |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Any kubernetes manifest file ending with '---' will
generate an error when applied using 'k8s' module.
Although this may not be 'legal' YAML, this is quite frequent,
specially on helm's generated manifest files.
migrated from ansible/ansible#59160
Signed-off-by: Abhijeet Kasurde akasurde@redhat.com
ISSUE TYPE
COMPONENT NAME
changelogs/fragments/59160_handle_none_def.yml
plugins/module_utils/raw.py