This repository has been archived by the owner on Jun 13, 2024. It is now read-only.
Ensure check mode results are as expected #155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #155 +/- ##
=======================================
Coverage 42.41% 42.41%
=======================================
Files 3 3
Lines 547 547
Branches 111 111
=======================================
Hits 232 232
Misses 271 271
Partials 44 44 Continue to review full report at Codecov.
|
check_mode with wait updates the result based on the existing resource which won't change with check_mode, so returns incorrect results. Only run the wait checks in non check_mode (this also avoids the issue of waiting for resource creation that will never happen in check mode)
willthames
force-pushed
the
check_mode_results
branch
from
60328dc to
e3223a8
Compare
geerlingguy
reviewed
Jul 9, 2020
geerlingguy
approved these changes
Jul 9, 2020
fabianvf
approved these changes
Jul 10, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
check_mode with wait updates the result based on the existing resource
which won't change with check_mode, so returns incorrect results.
Only run the wait checks in non check_mode (this also avoids the issue
of waiting for resource creation that will never happen in check mode)
ISSUE TYPE
COMPONENT NAME
raw