Skip to content
This repository has been archived by the owner on Jun 13, 2024. It is now read-only.

Create ns with helm #157

Merged
merged 2 commits into from
Jul 11, 2020
Merged

Create ns with helm #157

merged 2 commits into from
Jul 11, 2020

Conversation

LucasBoisserie
Copy link
Contributor

SUMMARY

Add Param to support --create-namespace flags
Fixes #108

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

helm

ADDITIONAL INFORMATION
- name: Deploy latest version of Prometheus chart inside monitoring namespace (and create it)
  community.kubernetes.helm:
    name: test
    chart_ref: stable/prometheus
    release_namespace: monitoring
    create_namespace: true

@codecov
Copy link

codecov bot commented Jul 9, 2020

Codecov Report

Merging #157 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #157   +/-   ##
=======================================
  Coverage   42.41%   42.41%           
=======================================
  Files           3        3           
  Lines         547      547           
  Branches      111      111           
=======================================
  Hits          232      232           
  Misses        271      271           
  Partials       44       44           
Impacted Files Coverage Δ
...ctions/community/kubernetes/plugins/modules/k8s.py 90.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ef6722d...f7b69d2. Read the comment docs.

@Akasurde Akasurde self-requested a review July 10, 2020 04:22
@Akasurde Akasurde self-assigned this Jul 10, 2020
plugins/modules/helm.py Outdated Show resolved Hide resolved
@Akasurde
Copy link
Member

Rest LGTM, waiting for others to comment.

Copy link
Collaborator

@fabianvf fabianvf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Akasurde Akasurde merged commit 3e971e0 into ansible-collections:master Jul 11, 2020
@Akasurde
Copy link
Member

@LucasBoisserie Thanks for the contribution. @fabianvf Thanks for the review.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Helm --create-namespace flag support
3 participants