This repository has been archived by the owner on Jun 13, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #16 +/- ##
=======================================
Coverage 43.28% 43.28%
=======================================
Files 3 3
Lines 536 536
Branches 109 109
=======================================
Hits 232 232
Misses 261 261
Partials 43 43
Continue to review full report at Codecov.
|
geerlingguy
suggested changes
Feb 17, 2020
geerlingguy
suggested changes
Feb 17, 2020
djzager
reviewed
Feb 18, 2020
@geerlingguy think I fixed everything, ready for review again |
geerlingguy
suggested changes
Feb 18, 2020
LGTM, if tests pass we can merge it! |
geerlingguy
approved these changes
Feb 18, 2020
This was referenced Feb 19, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Adds the k8s_log module, which allows you to pull logs from any resource that supports the /log endpoint (mostly just Pods I think).
ISSUE TYPE
COMPONENT NAME
k8s_log
ADDITIONAL INFORMATION
I've added a test (and verified it worked locally), but it requires a real kubernetes cluster, not just the api server, so I didn't include it from the existing test playbooks.