Skip to content
This repository has been archived by the owner on Jun 13, 2024. It is now read-only.

Add k8s_log module #16

Merged
merged 6 commits into from
Feb 18, 2020
Merged

Conversation

fabianvf
Copy link
Collaborator

@fabianvf fabianvf commented Feb 6, 2020

SUMMARY

Adds the k8s_log module, which allows you to pull logs from any resource that supports the /log endpoint (mostly just Pods I think).

ISSUE TYPE
  • New Module Pull Request
COMPONENT NAME

k8s_log

ADDITIONAL INFORMATION

I've added a test (and verified it worked locally), but it requires a real kubernetes cluster, not just the api server, so I didn't include it from the existing test playbooks.

@geerlingguy
Copy link
Collaborator

@fabianvf - If you get a chance, can you rebase, just to make sure tests pass? I'm still working on the new kind-cluster-based tests, but at least the tests should pass since #13 is resolved.

@geerlingguy geerlingguy added the type/enhancement New feature or request label Feb 11, 2020
@codecov-io
Copy link

codecov-io commented Feb 17, 2020

Codecov Report

Merging #16 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #16   +/-   ##
=======================================
  Coverage   43.28%   43.28%           
=======================================
  Files           3        3           
  Lines         536      536           
  Branches      109      109           
=======================================
  Hits          232      232           
  Misses        261      261           
  Partials       43       43
Flag Coverage Δ
#_ 43.28% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7067700...875c5df. Read the comment docs.

molecule/default/tasks/log.yml Outdated Show resolved Hide resolved
plugins/modules/k8s_log.py Outdated Show resolved Hide resolved
plugins/modules/k8s_log.py Outdated Show resolved Hide resolved
@fabianvf
Copy link
Collaborator Author

@geerlingguy think I fixed everything, ready for review again

plugins/modules/k8s_log.py Outdated Show resolved Hide resolved
@geerlingguy
Copy link
Collaborator

LGTM, if tests pass we can merge it!

@geerlingguy geerlingguy merged commit 2ba9116 into ansible-collections:master Feb 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type/enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants