This repository has been archived by the owner on Jun 13, 2024. It is now read-only.
add Makefile and downstream build script #197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Akasurde @geerlingguy @fabianvf I'm not entirely sure that to do here for integration tests for downstream, I almost feel like we should handle that async elsewhere in a non-blocking way on the upstream repo. Thoughts? |
Codecov Report
@@ Coverage Diff @@
## main #197 +/- ##
=======================================
Coverage 43.18% 43.18%
=======================================
Files 4 4
Lines 609 609
Branches 121 121
=======================================
Hits 263 263
Misses 298 298
Partials 48 48 Continue to review full report at Codecov.
|
maxamillion
force-pushed
the
downstream_build
branch
from
94338c4 to
3bb0226
Compare
Akasurde
approved these changes
Aug 26, 2020
Signed-off-by: Adam Miller <admiller@redhat.com>
maxamillion
force-pushed
the
downstream_build
branch
from
3bb0226 to
3885eb1
Compare
geerlingguy
suggested changes
Aug 26, 2020
Signed-off-by: Adam Miller <admiller@redhat.com>
Signed-off-by: Adam Miller <admiller@redhat.com>
Signed-off-by: Adam Miller <admiller@redhat.com>
Signed-off-by: Adam Miller <admiller@redhat.com>
Signed-off-by: Adam Miller <admiller@redhat.com>
geerlingguy
approved these changes
Aug 27, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Fixes #195
ISSUE TYPE
COMPONENT NAME
Makefile