Skip to content
This repository has been archived by the owner on Jun 13, 2024. It is now read-only.

helm: Add replace parameter #214

Merged
merged 1 commit into from
Sep 7, 2020
Merged

Conversation

Akasurde
Copy link
Member

SUMMARY

Fixes: #106

Signed-off-by: Abhijeet Kasurde akasurde@redhat.com

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

changelogs/fragments/106-helm_replace.yml
molecule/default/roles/helm/tasks/tests_chart.yml
plugins/modules/helm.py

@Akasurde
Copy link
Member Author

@LucasBoisserie Could you please review this? Thanks.

@codecov
Copy link

codecov bot commented Aug 31, 2020

Codecov Report

Merging #214 into main will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #214   +/-   ##
=======================================
  Coverage   43.18%   43.18%           
=======================================
  Files           4        4           
  Lines         609      609           
  Branches      121      121           
=======================================
  Hits          263      263           
  Misses        298      298           
  Partials       48       48           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 60c762b...7e4ad67. Read the comment docs.

Copy link
Collaborator

@fabianvf fabianvf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one issue I spotted, otherwise looks great

plugins/modules/helm.py Outdated Show resolved Hide resolved
Fixes: ansible-collections#106

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
@Akasurde Akasurde merged commit c49f896 into ansible-collections:main Sep 7, 2020
@Akasurde Akasurde deleted the i106 branch September 7, 2020 07:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement helm install --replace
2 participants