This repository has been archived by the owner on Jun 13, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #230 +/- ##
==========================================
- Coverage 41.26% 36.74% -4.53%
==========================================
Files 3 3
Lines 630 724 +94
Branches 126 144 +18
==========================================
+ Hits 260 266 +6
- Misses 322 409 +87
- Partials 48 49 +1
Continue to review full report at Codecov.
|
geerlingguy
suggested changes
Sep 16, 2020
Akasurde
changed the title
[wip] Add support for template in k8s module
k8s: add support for template
Sep 21, 2020
Akasurde
force-pushed
the
i37
branch
2 times, most recently
from
September 21, 2020 15:46
4b75fc3
to
1b52504
Compare
maxamillion
approved these changes
Sep 21, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
geerlingguy
suggested changes
Sep 21, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just for easier browsing of test results, I suggested a few lines to change in the test tasks.
fabianvf
reviewed
Sep 21, 2020
Akasurde
force-pushed
the
i37
branch
4 times, most recently
from
September 22, 2020 09:27
9d890df
to
a19618c
Compare
fabianvf
reviewed
Sep 24, 2020
fabianvf
approved these changes
Sep 25, 2020
Fixes: ansible-collections#37 Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Signed-off-by: Abhijeet Kasurde akasurde@redhat.com
ISSUE TYPE
COMPONENT NAME
plugins/action/k8s_info.py
plugins/module_utils/raw.py