Skip to content
This repository has been archived by the owner on Jun 13, 2024. It is now read-only.

k8s: add support for template #230

Merged
merged 1 commit into from
Sep 28, 2020
Merged

Conversation

Akasurde
Copy link
Member

SUMMARY

Signed-off-by: Abhijeet Kasurde akasurde@redhat.com

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

plugins/action/k8s_info.py
plugins/module_utils/raw.py

@codecov
Copy link

codecov bot commented Sep 16, 2020

Codecov Report

Merging #230 into main will decrease coverage by 4.52%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #230      +/-   ##
==========================================
- Coverage   41.26%   36.74%   -4.53%     
==========================================
  Files           3        3              
  Lines         630      724      +94     
  Branches      126      144      +18     
==========================================
+ Hits          260      266       +6     
- Misses        322      409      +87     
- Partials       48       49       +1     
Impacted Files Coverage Δ
...ns/community/kubernetes/plugins/action/k8s_info.py 21.83% <0.00%> (-31.24%) ⬇️
...ctions/community/kubernetes/plugins/modules/k8s.py 97.77% <0.00%> (+0.05%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f03d2ce...d03e7d7. Read the comment docs.

@Akasurde Akasurde changed the title [wip] Add support for template in k8s module k8s: add support for template Sep 21, 2020
@Akasurde Akasurde force-pushed the i37 branch 2 times, most recently from 4b75fc3 to 1b52504 Compare September 21, 2020 15:46
Copy link
Contributor

@maxamillion maxamillion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Copy link
Collaborator

@geerlingguy geerlingguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just for easier browsing of test results, I suggested a few lines to change in the test tasks.

molecule/default/tasks/template.yml Outdated Show resolved Hide resolved
molecule/default/tasks/template.yml Outdated Show resolved Hide resolved
molecule/default/tasks/template.yml Outdated Show resolved Hide resolved
molecule/default/tasks/template.yml Outdated Show resolved Hide resolved
plugins/action/k8s_info.py Outdated Show resolved Hide resolved
plugins/action/k8s_info.py Outdated Show resolved Hide resolved
@Akasurde Akasurde force-pushed the i37 branch 4 times, most recently from 9d890df to a19618c Compare September 22, 2020 09:27
Fixes: ansible-collections#37

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants