This repository has been archived by the owner on Jun 13, 2024. It is now read-only.
k8s_info now outputs whether the api was found #308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #308 +/- ##
==========================================
- Coverage 37.00% 36.95% -0.06%
==========================================
Files 3 3
Lines 727 728 +1
Branches 144 144
==========================================
Hits 269 269
- Misses 409 410 +1
Partials 49 49
Continue to review full report at Codecov.
|
Previously, an empty list of resources could mean two things: 1. There were no instances of resources matching the api_version and kind found in the cluster. 2. There was no API found that matched the provided api_version and kind. This adds a new field to the k8s_info output, `api_found`, which is a boolean that allows this ambiguity to be resolved by the user without additional steps.
fabianvf
force-pushed
the
return-api-discovered
branch
from
864da95 to
c32a14c
Compare
fabianvf
commented
Nov 18, 2020
This was referenced Jun 10, 2021
Closed
This was referenced Oct 27, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Previously, an empty list of resources could mean two things:
kind found in the cluster.
kind.
This adds a new field to the k8s_info output,
api_found, which is aboolean that allows this ambiguity to be resolved by the user without
additional steps.
ISSUE TYPE
COMPONENT NAME
k8s_info
ADDITIONAL INFORMATION