This repository has been archived by the owner on Jun 13, 2024. It is now read-only.
k8s: handle remote src and kubeconfig #320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Akasurde
requested review from
fabianvf,
geerlingguy,
tima,
gravesm and
goneri
Codecov Report
@@ Coverage Diff @@
## main #320 +/- ##
==========================================
- Coverage 37.03% 37.02% -0.02%
==========================================
Files 3 3
Lines 729 732 +3
Branches 144 144
==========================================
+ Hits 270 271 +1
- Misses 410 412 +2
Partials 49 49
Continue to review full report at Codecov.
|
Akasurde
force-pushed
the
remote_src
branch
7 times, most recently
from
3201405 to
475bd3c
Compare
fabianvf
reviewed
Dec 3, 2020
|
recheck |
Akasurde
changed the title
|
one of two issues of #307 is solved thanks to this PR. 👍 |
tima
suggested changes
Dec 4, 2020
Akasurde
force-pushed
the
remote_src
branch
3 times, most recently
from
74397d8 to
b35e5e5
Compare
Akasurde
changed the title
remote_src is boolean parameter to specify if src file is located on remote node or Ansible Controller. Fixes: ansible-collections#307 Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
goneri
reviewed
Dec 9, 2020
fabianvf
suggested changes
Dec 9, 2020
fabianvf
approved these changes
Dec 9, 2020
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
goneri
approved these changes
Dec 10, 2020
goneri
added a commit
to goneri/community.kubernetes
that referenced
this pull request
Dec 10, 2020
Depends-On: ansible-collections#320 Break down the long `run()` method to simplify the readability of the plugin.
goneri
added a commit
to goneri/community.kubernetes
that referenced
this pull request
Dec 10, 2020
Depends-On: ansible-collections#320 Break down the long `run()` method to simplify the readability of the plugin.
goneri
added a commit
to goneri/community.kubernetes
that referenced
this pull request
Dec 10, 2020
Depends-On: ansible-collections#320 Break down the long `run()` method to simplify the readability of the plugin.
|
Thank you @Akasurde :-). |
goneri
added a commit
to goneri/community.kubernetes
that referenced
this pull request
Jan 8, 2021
Depends-On: ansible-collections#320 Break down the long `run()` method to simplify the readability of the plugin.
goneri
added a commit
to goneri/community.kubernetes
that referenced
this pull request
Jan 8, 2021
Depends-On: ansible-collections#320 Break down the long `run()` method to simplify the readability of the plugin.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Add logic to specify if
src file is located on a remote node or Ansible Controller.
Add logic to specify if
kubeconfig file is located on the remote node or Ansible Controller.
Fixes: #307
Signed-off-by: Abhijeet Kasurde akasurde@redhat.com
ISSUE TYPE
COMPONENT NAME
changelogs/fragments/307_remote_src.yml
plugins/action/k8s_info.py