This repository has been archived by the owner on Jun 13, 2024. It is now read-only.
k8s_log no longer attempts to parse log as JSON #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes ansible-collections#68 Rather than relying on the default serialization logic (which attempts to parse a log as JSON and then load it into a wrapper class), we now simply return the raw log data as expected. The previous behavior worked in many cases because the log was serialized into a JSON string, but in the case of ansible-collections#68 the log was loaded as a JSON float, which made the error handling fail to fallback to returning the raw data.
Codecov Report
@@ Coverage Diff @@
## master #69 +/- ##
=======================================
Coverage 43.33% 43.33%
=======================================
Files 3 3
Lines 540 540
Branches 109 109
=======================================
Hits 234 234
Misses 263 263
Partials 43 43 Continue to review full report at Codecov.
|
geerlingguy
reviewed
Mar 31, 2020
fabianvf
commented
Mar 31, 2020
geerlingguy
suggested changes
Apr 1, 2020
geerlingguy
approved these changes
Apr 1, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Fixes #68
Rather than relying on the default serialization logic (which attempts to parse a log as JSON and then load it into a wrapper class), we now simply return the raw log data as expected. The previous behavior worked in many cases because the log was serialized into a JSON string, but in the case of #68 the log was loaded as a JSON float, which made the error handling fail to fallback to returning the raw data.
ISSUE TYPE
COMPONENT NAME
k8s_log