Skip to content
This repository has been archived by the owner on Jun 13, 2024. It is now read-only.

Fixes #96: Sanity test finds incorrect deprecated usage. #97

Merged
merged 1 commit into from
May 14, 2020
Merged

Fixes #96: Sanity test finds incorrect deprecated usage. #97

merged 1 commit into from
May 14, 2020

Conversation

geerlingguy
Copy link
Collaborator

@geerlingguy geerlingguy commented May 14, 2020

Closes #96.

Since we don't ship a k8s_facts module in this collection at all, we don't need to account for it being aliased to k8s_info.

@geerlingguy geerlingguy requested a review from fabianvf May 14, 2020 14:20
@codecov
Copy link

codecov bot commented May 14, 2020

Codecov Report

Merging #97 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #97   +/-   ##
=======================================
  Coverage   43.22%   43.22%           
=======================================
  Files           3        3           
  Lines         539      539           
  Branches      109      109           
=======================================
  Hits          233      233           
  Misses        263      263           
  Partials       43       43           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4e40ac3...3e60cca. Read the comment docs.

Copy link
Collaborator

@fabianvf fabianvf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@geerlingguy geerlingguy merged commit 600fa44 into ansible-collections:master May 14, 2020
@geerlingguy geerlingguy deleted the 96-sanity-deprecated branch July 17, 2020 13:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI sanity test is returning new error about invalid deprecated version
2 participants