Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mysql_user: add session_vars argument #489

Merged
merged 2 commits into from
Jan 24, 2023
Merged

mysql_user: add session_vars argument #489

merged 2 commits into from
Jan 24, 2023

Conversation

Andersson007
Copy link
Collaborator

SUMMARY

Fixes #478

ISSUE TYPE
  • Feature Pull Request

@Andersson007
Copy link
Collaborator Author

@janggwan-im i created this PR to add the feature you need.
Do you have time to test this? Here's the short guide.
I think it's safe to merge it w/o manual testing as i added a couple of integration tests but i'd like to be sure this will solve your issue

russoz
russoz approved these changes Jan 20, 2023
View reviewed changes
Copy link
Contributor

@russoz russoz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tiny nit pick, other than that LGTM

tests/integration/targets/test_mysql_user/tasks/main.yml Outdated Show resolved Hide resolved
@Andersson007 @russoz
Update tests/integration/targets/test_mysql_user/tasks/main.yml
1ce6af2 
Co-authored-by: Alexei Znamensky <103110+russoz@users.noreply.github.com>
@Andersson007 Andersson007 merged commit 930a5a5 into ansible-collections:main Jan 24, 2023
@Andersson007
Copy link
Collaborator Author

@russoz thanks for reviewing!

@Andersson007 Andersson007 mentioned this pull request Jan 30, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@russoz russoz russoz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support the session variable wsrep_on = off for the Galera cluster
2 participants
@Andersson007 @russoz