Fix column uppercasing

[kmarse]

SUMMARY

This pull request is to add logic to remove uppercasing column level privileges as they are case sensitive per MySQL databases.

This fixes #399

ISSUE TYPE

• Feature Pull Request

COMPONENT NAME

plugins/modules/mysql_role.py
plugins/modules/mysql_user.py
plugins/module_utils/user.py

ADDITIONAL INFORMATION

[codecov]

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (8c2b6b0) 76.16% compared to head (ea60550) 74.40%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #569      +/-   ##
==========================================
- Coverage   76.16%   74.40%   -1.77%     
==========================================
  Files          28       18      -10     
  Lines        2379     2266     -113     
  Branches      579      564      -15     
==========================================
- Hits         1812     1686     -126     
- Misses        391      407      +16     
+ Partials      176      173       -3     

Flag	Coverage Δ
integration	73.83% <100.00%> (+0.18%)	⬆️
sanity	?
units	?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files	Coverage Δ
plugins/module_utils/user.py	84.87% <100.00%> (+0.12%)	⬆️
plugins/modules/mysql_role.py	75.00% <100.00%> (-6.17%)	⬇️
plugins/modules/mysql_user.py	83.78% <100.00%> (-0.33%)	⬇️

... and 17 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[Andersson007]

@kmarse hello, thanks for the PR!
Could you please:

• fix sanity errors
• add some integration tests for user and role to tests/integration/targets/*
• add a changelog fragment

if you have any questions, please ask

[laurent-indermuehle]

@Andersson007 I feel like we should change the default in 4.0 to true ! We could announce it like you did in #408. Are you ok?

@kmarse, hope you're doing well with everything on your plate recently. I've got the integration tests completed for the changes in #399 - they're all passing. I want to get this merged as soon as we can as #572 is blocked by it. When you get a chance, would you mind taking a look at either granting me push access to your fork's main branch so I can add the test files? Otherwise I can open a PR there but it's less easy. I appreciate you taking the time.

If you think you won't have bandwidth for it in the next day or two though, feel free to let me know and I can open a PR on my end to move things along. Just wanted to check in first since it's your code. Thanks so much!

[kmarse]

@laurent-indermuehle I have added you to my fork am just waiting your acceptance now. Sorry I am pretty busy on other projects and don't have the bandwidth to help a lot on this.

[laurent-indermuehle]

@kmarse thanks for the invitation, I accepted it. I'll try to push my tests tomorrow.

[Andersson007]

@Andersson007 I feel like we should change the default in 4.0 to true ! We could announce it like you did in #408. Are you ok?

@laurent-indermuehle yeah, i'm fine with that, thanks

[laurent-indermuehle]

I don't get why this PR has been closed.
Maybe it's because kmarse was on 3.7.0 and our main on 3.7.2. I rebased and pushed again.

[Andersson007]

@laurent-indermuehle thanks for continuing the work!
How about:

• Adding yourself and @kmarse to the authors: ?
• Adding a warning when the field is not set?

[laurent-indermuehle]

@laurent-indermuehle thanks for continuing the work! How about:

• Adding yourself and @kmarse to the authors: ?
• Adding a warning when the field is not set?

@Andersson007 module.params['column_case_sensitive'] seems to be always sets.

Then I made a simple test "if not column_case_sensitive". Hope that's ok: baf947d

[Andersson007]

@kmarse @laurent-indermuehle thanks a lot for the contribution!