Fix sanity for plugins #112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks. I've emailed @sabandi |
felixfontein
added a commit
that referenced
this pull request
Sep 28, 2020
* Mention sros netconf plugin deprecation in runtime.yml. * Fix sanity errors / missing FQCNs. * Fix avi lookup copyright and author. (cherry picked from commit bc7e3e3)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Fix some errors found with ansible/ansible#71734.
The most important change is fixing the avi lookup plugin, merged in ansible/ansible#58667. It does NOT contain a GPL copyright header (and the author's GitHub name was missing). @sabandi (the plugin's author) and @Qalthos (who merged the PR): do I assume correctly that the code is licensed under GPL v3+, as it was merged to Ansible as a plugin which are all expected to be GPL v3+ licensed?
CC @gundalow
ISSUE TYPE
COMPONENT NAME
plugins/lookup/avi.py
plugins/cliconf/eric_eccli.py
meta/runtime.yml