Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vmware_dvswitch_pvlans: The VLAN ID type has been updated to be handled as an integer #2267

Merged

Conversation

sky-joker
Copy link
Collaborator

@sky-joker sky-joker commented Dec 5, 2024

SUMMARY

This module had a bug that caused an error if the VLAN ID was a string type.
The argument_specs and documentation have been improved to address this issue.

fixes: #2216

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME
  • plugins/modules/vmware_dvswitch_pvlans.py
  • changelogs/fragments/2216-vmware_dvswitch_pvlans.yml
ADDITIONAL INFORMATION

Tested on VCSA 7.0

@sky-joker sky-joker changed the title [WIP] vmware_dvswitch_pvlans: The VLAN ID type has been updated to be handled as an integer vmware_dvswitch_pvlans: The VLAN ID type has been updated to be handled as an integer Dec 5, 2024
@mariolenz
Copy link
Collaborator

I'm sorry, I didn't find much time to work on this collection during the last weeks. I hope I'm able to review this PR soon.

Copy link
Collaborator

@mariolenz mariolenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks @sky-joker!

Copy link

Build succeeded (gate pipeline).
https://ansible.softwarefactory-project.io/zuul/buildset/86c68d5547794d1ca2c606d25d1eea6f

✔️ ansible-tox-linters SUCCESS in 4m 35s
✔️ build-ansible-collection SUCCESS in 6m 06s
✔️ ansible-galaxy-importer SUCCESS in 5m 29s

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit ddaa171 into ansible-collections:main Jan 18, 2025
13 checks passed
netbsd-srcmastr pushed a commit to NetBSD/pkgsrc that referenced this pull request Jan 29, 2025
11.2.0

Major Changes

community.general

- keycloak_* modules - ``refresh_token`` parameter added. When multiple authentication parameters are provided (``token``, ``refresh_token``, and ``auth_username``/``auth_password``), modules will now automatically retry requests upon authentication errors (401), using in order the token, refresh token, and username/password (ansible-collections/community.general#9494).

community.vmware

- vmware_dvswitch_pvlans - The VLAN ID type has been updated to be handled as an integer (ansible-collections/community.vmware#2267).

dellemc.openmanage

- omevv_firmware - This module allows to update firmware of the single host and single cluster.

fortinet.fortios

- Support check_mode on all the configuration modules.

google.cloud

- google_cloud_ops_agents - role submodule removed because it prevents the collection from passing sanity and lint tests

grafana.grafana

- Ability to set custom directory path for *.alloy config files
- Fix 'dict object' has no attribute 'path' when running with --check
- Update grafana template
- add loki bloom support
- grafana.ini yaml syntax
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

vmware_dvswitch_pvlans: For "primaryVlanId" expected type int, but got str
2 participants