Skip to content

Commit

Permalink
Adding "name" to Cloud Build resource
Browse files Browse the repository at this point in the history
Signed-off-by: Modular Magician <magic-modules@google.com>
  • Loading branch information
WillBeebe authored and modular-magician committed Oct 18, 2019
1 parent e0d101b commit 521c052
Show file tree
Hide file tree
Showing 2 changed files with 20 additions and 4 deletions.
19 changes: 15 additions & 4 deletions plugins/modules/gcp_cloudbuild_trigger.py
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,12 @@
- The unique identifier for the trigger.
required: false
type: str
name:
description:
- Name of the trigger. Must be unique within the project.
required: false
type: str
version_added: '2.10'
description:
description:
- Human-readable description of the trigger.
Expand Down Expand Up @@ -368,6 +374,11 @@
- The unique identifier for the trigger.
returned: success
type: str
name:
description:
- Name of the trigger. Must be unique within the project.
returned: success
type: str
description:
description:
- Human-readable description of the trigger.
Expand Down Expand Up @@ -625,6 +636,7 @@ def main():
argument_spec=dict(
state=dict(default='present', choices=['present', 'absent'], type='str'),
id=dict(type='str'),
name=dict(type='str'),
description=dict(type='str'),
disabled=dict(type='bool'),
substitutions=dict(type='dict'),
Expand Down Expand Up @@ -675,10 +687,7 @@ def main():

state = module.params['state']

if module.params['id']:
fetch = fetch_resource(module, self_link(module))
else:
fetch = {}
fetch = fetch_resource(module, self_link(module))
changed = False

if fetch:
Expand Down Expand Up @@ -721,6 +730,7 @@ def delete(module, link):
def resource_to_request(module):
request = {
u'id': module.params.get('id'),
u'name': module.params.get('name'),
u'description': module.params.get('description'),
u'disabled': module.params.get('disabled'),
u'substitutions': module.params.get('substitutions'),
Expand Down Expand Up @@ -795,6 +805,7 @@ def is_different(module, response):
def response_to_hash(module, response):
return {
u'id': response.get(u'id'),
u'name': response.get(u'name'),
u'description': response.get(u'description'),
u'disabled': response.get(u'disabled'),
u'createTime': response.get(u'createTime'),
Expand Down
5 changes: 5 additions & 0 deletions plugins/modules/gcp_cloudbuild_trigger_info.py
Original file line number Diff line number Diff line change
Expand Up @@ -109,6 +109,11 @@
- The unique identifier for the trigger.
returned: success
type: str
name:
description:
- Name of the trigger. Must be unique within the project.
returned: success
type: str
description:
description:
- Human-readable description of the trigger.
Expand Down

0 comments on commit 521c052

Please sign in to comment.