Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

k8s_scale - add option label_selectors and continue_on_error #114

Merged
merged 14 commits into from
Jun 7, 2021

Conversation

abikouo
Copy link
Contributor

@abikouo abikouo commented May 25, 2021

SUMMARY

k8s_scale - add new parameter label_selectors to support scale for multiple resources, and new parameter continue_on_error to determine wether to continue with others resources when an error occurs.

#112

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

k8s_scale

ADDITIONAL INFORMATION
- kubernetes.core.k8s_scale:
    kind: Deployment
    namespace: default
    label_selectors:
      - app = test
    replicas: 3

abikouo and others added 2 commits May 25, 2021 16:25
…rror.yaml to 114-k8s_scale-add-label-selectors-and-continue-on-error.yaml
@codecov
Copy link

codecov bot commented May 25, 2021

Codecov Report

Merging #114 (9eeaf9b) into main (5b5777d) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #114   +/-   ##
=======================================
  Coverage   24.02%   24.02%           
=======================================
  Files           1        1           
  Lines         154      154           
  Branches       29       29           
=======================================
  Hits           37       37           
- Misses        111      112    +1     
+ Partials        6        5    -1     
Impacted Files Coverage Δ
...ections/kubernetes/core/plugins/action/k8s_info.py 24.02% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5b5777d...9eeaf9b. Read the comment docs.

@abikouo abikouo requested review from gravesm and Akasurde May 26, 2021 11:39
Copy link
Member

@Akasurde Akasurde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

abikouo and others added 6 commits June 1, 2021 10:29
Co-authored-by: Abhijeet Kasurde <akasurde@redhat.com>
Co-authored-by: Abhijeet Kasurde <akasurde@redhat.com>
Co-authored-by: Abhijeet Kasurde <akasurde@redhat.com>
…tinue-on-error.yaml

Co-authored-by: Abhijeet Kasurde <akasurde@redhat.com>
@abikouo abikouo requested a review from Akasurde June 2, 2021 12:39
@abikouo abikouo merged commit 481521a into ansible-collections:main Jun 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants