k8s apply - fix list merge for array attribute with empty dict #131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #131 +/- ##
=======================================
Coverage 24.02% 24.02%
=======================================
Files 1 1
Lines 154 154
Branches 29 29
=======================================
Hits 37 37
Misses 111 111
Partials 6 6 Continue to review full report at Codecov.
|
abikouo
force-pushed
the
apply_change_empty_array
branch
from
3410a95 to
4e77f40
Compare
gravesm
requested changes
Jun 14, 2021
changelogs/fragments/129-k8s-fix-apply-array-with-empty-dict.yml
Outdated
Show resolved
Hide resolved
Co-authored-by: Mike Graves <mgraves@redhat.com>
gravesm
approved these changes
Jun 14, 2021
abikouo
added a commit
to abikouo/kubernetes.core
that referenced
this pull request
Jun 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
k8sapply is not working as expected when an array attribute contains empty dictFixes #113
ISSUE TYPE
COMPONENT NAME
k8s