-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add sinceSeconds parameter to k8s_logs #142
Conversation
Co-authored-by: Abhijeet Kasurde <akasurde@redhat.com>
@stg-0 Thanks for the PR! The rst docs will be auto-generated from the module docs so you can remove that file. You should update one of the examples in the k8s_log.py module file instead. |
Codecov Report
@@ Coverage Diff @@
## main #142 +/- ##
=======================================
Coverage 24.02% 24.02%
=======================================
Files 1 1
Lines 154 154
Branches 29 29
=======================================
Hits 37 37
- Misses 111 112 +1
+ Partials 6 5 -1
Continue to review full report at Codecov.
|
Co-authored-by: Mike Graves <mgraves@redhat.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @stg-0!
5b45b10
to
8ca5321
Compare
@stg-0 Thanks for the contribution. |
SUMMARY
This simple PR aims to add the sinceSeconds API's parameter to the k8s_log module so we can limit the output since it can be huge in some cases.
ISSUE TYPE
COMPONENT NAME
k8s_log
ADDITIONAL INFORMATION