Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow turbo mode, but disabled by default #190

Conversation

goneri
Copy link
Member

@goneri goneri commented Jul 28, 2021

Depends-On: ansible-collections/cloud.common#73

Expose a new parameter called enable_session_cache to enable the
feature.

@gravesm
Copy link
Member

gravesm commented Jul 29, 2021

This option will need to be added to most of the k8s_* modules.

@goneri
Copy link
Member Author

goneri commented Jul 29, 2021

This option will need to be added to most of the k8s_* modules.

Yes, I'm doing my test with just k8s for now. @gravesm How do you feel with this design?

@gravesm
Copy link
Member

gravesm commented Jul 29, 2021

I think an env var or a global ansible setting would be a better solution, but I understand those will be much more difficult to implement. I'll do some testing on my own end to see how this works.

@goneri goneri force-pushed the allow-turbo-mode-but-disabled-by-default_11551 branch from a72c9e6 to 5e88338 Compare July 29, 2021 15:35
@goneri goneri force-pushed the allow-turbo-mode-but-disabled-by-default_11551 branch from 5e88338 to 7d4e0ee Compare August 19, 2021 19:58
@goneri goneri changed the title WIP - allow turbo mode, but disabled by default allow turbo mode, but disabled by default Aug 19, 2021
@goneri goneri force-pushed the allow-turbo-mode-but-disabled-by-default_11551 branch from 7d4e0ee to 59fa298 Compare August 19, 2021 20:15
Depends-On: ansible-collections/cloud.common#73

Expose a new parameter called enable_session_cache to enable the
feature.
@goneri goneri force-pushed the allow-turbo-mode-but-disabled-by-default_11551 branch from 59fa298 to 6bfcdc8 Compare August 19, 2021 20:38
@goneri
Copy link
Member Author

goneri commented Aug 23, 2021

Superseded by #169

@goneri goneri closed this Aug 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants