-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Documentation update for kubernetes.core.helm #317
Conversation
- Clarify usage of the module for doing `helm repo update` only.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If there is a desire to update the repo cache in a separate step, I would rather see us provide more explicit functionality to do that, probably in the |
On Mon, Jan 10, 2022 at 07:08:32AM -0800, Mike Graves wrote:
If there is a desire to update the repo cache in a separate step, I
would rather see us provide more explicit functionality to do that,
probably in the `helm_repository` module. This workaround is
potentially problematic because it relies on choosing a release name
that isn't in use.
I agree. However, right now, the documentation hints that it is possible
but do not specify how, which is confusing. Documenting the workaround
until a specific option is provided will avoid users wasting time
searching for how to use the documented feature.
|
recheck |
@gravesm Updating repo using For now, I think this is OK. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, that's fine.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Clarify usage of the module for doing
helm repo update
only.I used collection_prep_add_docs as explained in CONTRIBUTING.md, not sure if
that's correct ?
Fixes #316
@Akasurde