Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation update for kubernetes.core.helm #317

Merged
merged 1 commit into from
Jan 13, 2022

Conversation

VannTen
Copy link
Contributor

@VannTen VannTen commented Dec 28, 2021

Clarify usage of the module for doing helm repo update only.

I used collection_prep_add_docs as explained in CONTRIBUTING.md, not sure if
that's correct ?

Fixes #316
@Akasurde

- Clarify usage of the module for doing `helm repo update` only.
Copy link
Member

@Akasurde Akasurde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, @abikouo @gravesm What do you think?

@gravesm
Copy link
Member

gravesm commented Jan 10, 2022

If there is a desire to update the repo cache in a separate step, I would rather see us provide more explicit functionality to do that, probably in the helm_repository module. This workaround is potentially problematic because it relies on choosing a release name that isn't in use.

@VannTen
Copy link
Contributor Author

VannTen commented Jan 11, 2022 via email

@Akasurde
Copy link
Member

recheck

@Akasurde
Copy link
Member

@gravesm Updating repo using helm_repository will also be the same since repo_url and repo_name will be required.

For now, I think this is OK.

Copy link
Member

@gravesm gravesm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, that's fine.

Copy link

@ansible-zuul ansible-zuul bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ansible-zuul ansible-zuul bot merged commit 9a0b3fe into ansible-collections:main Jan 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document usage of kubernetes.core.helm to do a helm repo update
3 participants