Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replicate apply method in the DynamicClient #45

Merged
merged 13 commits into from
Apr 22, 2021

Conversation

alinabuzachis
Copy link
Contributor

@alinabuzachis alinabuzachis commented Apr 8, 2021

SUMMARY

Replicate apply method in the DynamicClient.

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

@alinabuzachis alinabuzachis force-pushed the dynamic_client_apply branch 3 times, most recently from 2dd6c14 to c85ab00 Compare April 8, 2021 16:17
@alinabuzachis alinabuzachis changed the title Replicate apply method in the DynamicClient [WIP] Replicate apply method in the DynamicClient Apr 9, 2021
@alinabuzachis alinabuzachis force-pushed the dynamic_client_apply branch 5 times, most recently from 51fe288 to 79adba3 Compare April 9, 2021 13:01
@alinabuzachis alinabuzachis changed the title [WIP] Replicate apply method in the DynamicClient Replicate apply method in the DynamicClient Apr 9, 2021
@alinabuzachis alinabuzachis force-pushed the dynamic_client_apply branch 20 times, most recently from f0b4d5a to f5d0000 Compare April 12, 2021 19:29
@alinabuzachis alinabuzachis force-pushed the dynamic_client_apply branch 4 times, most recently from d5ce60a to 3197566 Compare April 15, 2021 13:04
@codecov
Copy link

codecov bot commented Apr 15, 2021

Codecov Report

Merging #45 (e5aaadd) into main (c214376) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #45   +/-   ##
=======================================
  Coverage   23.17%   23.17%           
=======================================
  Files           1        1           
  Lines         151      151           
  Branches       24       24           
=======================================
  Hits           35       35           
  Misses        111      111           
  Partials        5        5           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c214376...e5aaadd. Read the comment docs.

@alinabuzachis alinabuzachis force-pushed the dynamic_client_apply branch 4 times, most recently from ba89665 to 2d18973 Compare April 16, 2021 12:19
Signed-off-by: Alina Buzachis <abuzachis@redhat.com>
Signed-off-by: Alina Buzachis <abuzachis@redhat.com>
Signed-off-by: Alina Buzachis <abuzachis@redhat.com>
Signed-off-by: Alina Buzachis <abuzachis@redhat.com>
Signed-off-by: Alina Buzachis <abuzachis@redhat.com>
Signed-off-by: Alina Buzachis <abuzachis@redhat.com>
Signed-off-by: Alina Buzachis <abuzachis@redhat.com>
Signed-off-by: Alina Buzachis <abuzachis@redhat.com>
Signed-off-by: Alina Buzachis <abuzachis@redhat.com>
Signed-off-by: Alina Buzachis <abuzachis@redhat.com>
Signed-off-by: Alina Buzachis <abuzachis@redhat.com>
Signed-off-by: Alina Buzachis <abuzachis@redhat.com>
Signed-off-by: Alina Buzachis <abuzachis@redhat.com>
Copy link
Member

@gravesm gravesm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work on this!

@gravesm gravesm merged commit 48c5170 into ansible-collections:main Apr 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants