k8s inventory - remove trailing slashes from hostname #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When user provides hostname with trailing slashes like https://localhost:6443/, the openshift library fails to enumerate the APIs from the given cluster. This fix removes any extra trailing slashes before sending it to the openshift DynamicClient. Fixes: ansible-collections#52 Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
Codecov Report
@@ Coverage Diff @@
## main #63 +/- ##
=======================================
Coverage 23.17% 23.17%
=======================================
Files 1 1
Lines 151 151
Branches 24 24
=======================================
Hits 35 35
Misses 111 111
Partials 5 5 Continue to review full report at Codecov.
|
|
@Akasurde would be nice to add some molecule tests along with |
abikouo
approved these changes
Apr 19, 2021
gravesm
approved these changes
Apr 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
When user provides hostname with trailing slashes like
https://localhost:6443/, the openshift library fails to
enumerate the APIs from the given cluster.
This fix removes any extra trailing slashes before sending it
to the openshift DynamicClient.
Fixes: #52
Signed-off-by: Abhijeet Kasurde akasurde@redhat.com
ISSUE TYPE
COMPONENT NAME
changelogs/fragments/52_inventory.yml
plugins/module_utils/common.py