helm: accept context and validate_certs #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #74 +/- ##
=======================================
Coverage 23.17% 23.17%
=======================================
Files 1 1
Lines 151 151
Branches 24 24
=======================================
Hits 35 35
Misses 111 111
Partials 5 5 Continue to review full report at Codecov.
|
I've got the following environment variable set: - `K8S_AUTH_VERIFY_SSL=False` Helm's `validate_certs` parameter fallback on this environment variable. Which means, on my system, the `validate_certs` will already be set. So we cannot make this parameter exclusive wih another one.
goneri
force-pushed
the
helm-accept-context-and-validate_certs_26739
branch
from
0890c45 to
61d94ab
Compare
gravesm
approved these changes
Apr 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've got the following environment variable set:
K8S_AUTH_VERIFY_SSL=FalseHelm's
validate_certsparameter fallback on this environment variable.Which means, on my system, the
validate_certswill already be set.So we cannot make this parameter exclusive wih another one.