Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ansible install step from kubevirt GHA #757

Merged
merged 1 commit into from
Jul 9, 2024

Conversation

gravesm
Copy link
Member

@gravesm gravesm commented Jul 9, 2024

SUMMARY

Ansible 2.17 is already included in the ubuntu-latest runner image, so there's no need for a separate install step. It was broken in any case because the python version being used was too low for ansible 2.18.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME
ADDITIONAL INFORMATION

Ansible 2.17 is already included in the ubuntu-latest runner image, so
there's no need for a separate install step. It was broken in any case
because the python version being used was too low for ansible 2.18.
Copy link

Copy link

Build succeeded (gate pipeline).
https://ansible.softwarefactory-project.io/zuul/buildset/0cb3e18ee93c4b9e8bfbfdb2ee845567

✔️ ansible-galaxy-importer SUCCESS in 5m 03s
✔️ build-ansible-collection SUCCESS in 7m 07s

Copy link

Pull request merge failed: Resource not accessible by integration, You may need to manually rebase your PR and retry.

@gravesm gravesm merged commit 44a2fc3 into ansible-collections:main Jul 9, 2024
46 checks passed
Copy link

patchback bot commented Jul 9, 2024

Backport to stable-3: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-3/44a2fc392a1c795264da2fbfc2ade85444574ef4/pr-757

Backported as #758

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

@gravesm gravesm deleted the gha-python-version branch July 9, 2024 15:52
patchback bot pushed a commit that referenced this pull request Jul 9, 2024
Remove ansible install step from kubevirt GHA

(cherry picked from commit 44a2fc3)
Copy link

patchback bot commented Jul 9, 2024

Backport to stable-5: 💔 cherry-picking failed — conflicts found

❌ Failed to cleanly apply 44a2fc3 on top of patchback/backports/stable-5/44a2fc392a1c795264da2fbfc2ade85444574ef4/pr-757

Backporting merged PR #757 into main

  1. Ensure you have a local repo clone of your fork. Unless you cloned it
    from the upstream, this would be your origin remote.
  2. Make sure you have an upstream repo added as a remote too. In these
    instructions you'll refer to it by the name upstream. If you don't
    have it, here's how you can add it:
    $ git remote add upstream https://github.com/ansible-collections/kubernetes.core.git
  3. Ensure you have the latest copy of upstream and prepare a branch
    that will hold the backported code:
    $ git fetch upstream
    $ git checkout -b patchback/backports/stable-5/44a2fc392a1c795264da2fbfc2ade85444574ef4/pr-757 upstream/stable-5
  4. Now, cherry-pick PR Remove ansible install step from kubevirt GHA #757 contents into that branch:
    $ git cherry-pick -x 44a2fc392a1c795264da2fbfc2ade85444574ef4
    If it'll yell at you with something like fatal: Commit 44a2fc392a1c795264da2fbfc2ade85444574ef4 is a merge but no -m option was given., add -m 1 as follows instead:
    $ git cherry-pick -m1 -x 44a2fc392a1c795264da2fbfc2ade85444574ef4
  5. At this point, you'll probably encounter some merge conflicts. You must
    resolve them in to preserve the patch from PR Remove ansible install step from kubevirt GHA #757 as close to the
    original as possible.
  6. Push this branch to your fork on GitHub:
    $ git push origin patchback/backports/stable-5/44a2fc392a1c795264da2fbfc2ade85444574ef4/pr-757
  7. Create a PR, ensure that the CI is green. If it's not — update it so that
    the tests and any other checks pass. This is it!
    Now relax and wait for the maintainers to process your pull request
    when they have some cycles to do reviews. Don't worry — they'll tell you if
    any improvements are necessary when the time comes!

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

softwarefactory-project-zuul bot pushed a commit that referenced this pull request Jul 10, 2024
This is a backport of PR #757 as merged into main (44a2fc3).
SUMMARY

Ansible 2.17 is already included in the ubuntu-latest runner image, so there's no need for a separate install step. It was broken in any case because the python version being used was too low for ansible 2.18.

ISSUE TYPE


Bugfix Pull Request

COMPONENT NAME

ADDITIONAL INFORMATION

Reviewed-by: Mike Graves <mgraves@redhat.com>
gravesm added a commit to gravesm/kubernetes.core that referenced this pull request Jul 10, 2024
…rsion

Remove ansible install step from kubevirt GHA

(cherry picked from commit 44a2fc3)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants