Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support of local environment variables in kustomize lookup plugin #786

Open
wants to merge 28 commits into
base: main
Choose a base branch
from
Open

Add support of local environment variables in kustomize lookup plugin #786

wants to merge 28 commits into from

Conversation

yurnov
Copy link
Contributor

@yurnov yurnov commented Oct 30, 2024

SUMMARY

kustomize doesn't support an environment that makes it impossible to use HTTP_PROXY or provide some templatized parameters.

This PR is the result of the issue #783

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

kubernetes.core.kustomize lookup plugin

@yurnov yurnov mentioned this pull request Oct 30, 2024
Open
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/fb3f5896ab4d46e7879aeeaf94c3655b

✔️ ansible-galaxy-importer SUCCESS in 4m 14s
✔️ build-ansible-collection SUCCESS in 5m 49s

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/eadfed89ce2e47ffb2b61558c8e0583c

✔️ ansible-galaxy-importer SUCCESS in 2m 58s
✔️ build-ansible-collection SUCCESS in 5m 45s

@yurnov yurnov changed the title Add support of local environment variables in kustomize lookup plugin [WIP] Add support of local environment variables in kustomize lookup plugin Oct 30, 2024
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/f6250fe276b742f4a7c305df2fbd2146

✔️ ansible-galaxy-importer SUCCESS in 4m 27s
✔️ build-ansible-collection SUCCESS in 5m 37s

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/5f25e7ad91c44ae884bf7cd7ac9b79d3

✔️ ansible-galaxy-importer SUCCESS in 3m 55s
✔️ build-ansible-collection SUCCESS in 5m 35s

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/6875dcf672c747508f615f277244e99b

✔️ ansible-galaxy-importer SUCCESS in 4m 33s
✔️ build-ansible-collection SUCCESS in 5m 27s

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/fa99a9b775de4c598ad4ee685c0fc260

✔️ ansible-galaxy-importer SUCCESS in 4m 00s
✔️ build-ansible-collection SUCCESS in 5m 22s

@yurnov yurnov force-pushed the support_local_env_for_kustomize branch from f67c998 to f0691f5 Compare October 30, 2024 14:13
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/456ce8f595a74ab78e29374a6d3f2876

✔️ ansible-galaxy-importer SUCCESS in 7m 37s
✔️ build-ansible-collection SUCCESS in 5m 40s

@yurnov yurnov changed the title [WIP] Add support of local environment variables in kustomize lookup plugin Add support of local environment variables in kustomize lookup plugin Oct 30, 2024
@yurnov
Copy link
Contributor Author

yurnov commented Oct 30, 2024

Hi @abikouo,

could you please check for workflow, some sanity tests are failing on milestone and development and it seems that it is unrelated to this PR reason.

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/9da159d50bc44865949e54e5b219940c

✔️ ansible-galaxy-importer SUCCESS in 4m 23s
✔️ build-ansible-collection SUCCESS in 5m 20s

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/158d46e39bc348eaa4797e6e7f74746a

✔️ ansible-galaxy-importer SUCCESS in 4m 12s
✔️ build-ansible-collection SUCCESS in 5m 16s

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/922f8151bac54f9bbe873dcfdb17322b

✔️ ansible-galaxy-importer SUCCESS in 4m 13s
✔️ build-ansible-collection SUCCESS in 5m 15s

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/4c723b54c9a742feacc2c1c1d8b97a7b

✔️ ansible-galaxy-importer SUCCESS in 4m 52s
✔️ build-ansible-collection SUCCESS in 5m 16s

@yurnov
Copy link
Contributor Author

yurnov commented Nov 2, 2024

Hi @abikouo,

could you please check for workflow, some sanity tests are failing on milestone and development and it seems that it is unrelated to this PR reason.

I found that the root cause of the sanity failure was switching the devel and milestone branches of Ansible to version 2.19. The test was fixed by commit deff6ee, which was included in that PR. But I think I should probably create a new PR for CI (GitHub actions) related issues to have a much cleaner history.

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/ce88887bfee74cb785177b28ceb7b669

✔️ ansible-galaxy-importer SUCCESS in 10m 21s
✔️ build-ansible-collection SUCCESS in 5m 37s

@yurnov
Copy link
Contributor Author

yurnov commented Nov 2, 2024

PR #789 was created as I mentioned in previous comment, this PR should be rebased when 789 is merged.

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/5fa92c46099847aab26406ddd5846bc8

✔️ ansible-galaxy-importer SUCCESS in 4m 13s
✔️ build-ansible-collection SUCCESS in 5m 35s

abikouo
abikouo requested changes Nov 21, 2024
View reviewed changes
Copy link
Contributor

@abikouo abikouo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yurnov thanks for working on this issue.
Some minor things need to be changed.
If possible add some integration tests case for this feature into lookup_kustomize integration test target

plugins/lookup/kustomize.py Outdated Show resolved Hide resolved
plugins/lookup/kustomize.py Outdated Show resolved Hide resolved
plugins/lookup/kustomize.py Outdated Show resolved Hide resolved
plugins/lookup/kustomize.py Outdated Show resolved Hide resolved
@yurnov
Copy link
Contributor Author

yurnov commented Nov 21, 2024

I will check what can be done to integration test

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/367c0b3e90ed49a6932491cfaabe16f9

✔️ ansible-galaxy-importer SUCCESS in 3m 54s
✔️ build-ansible-collection SUCCESS in 5m 15s

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/ef01e17d36284663858d1b2df484a9f5

✔️ ansible-galaxy-importer SUCCESS in 4m 22s
✔️ build-ansible-collection SUCCESS in 5m 24s

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/4ccb73132a8f45a798a857b1b8a53f67

✔️ ansible-galaxy-importer SUCCESS in 5m 30s
✔️ build-ansible-collection SUCCESS in 6m 24s

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/24da250e2262401ea2d64a78ed076305

✔️ ansible-galaxy-importer SUCCESS in 6m 15s
✔️ build-ansible-collection SUCCESS in 5m 18s

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/20fb9932e4cc447b9c429b61dd5ed56e

✔️ ansible-galaxy-importer SUCCESS in 3m 52s
✔️ build-ansible-collection SUCCESS in 5m 18s

@yurnov yurnov force-pushed the support_local_env_for_kustomize branch 3 times, most recently from 1f62e46 to 104572f Compare November 21, 2024 20:31
yurnov added 24 commits January 21, 2025 12:54
@yurnov
fix W293: blank line contains whitespace
26d85f0
@yurnov
fix using of evrion
4a78413
@yurnov
reformat with black
4655376
@yurnov
change approach of support enviromental variable
e85e95a
@yurnov
fix typo envion e -> envrion
c6f6723
@yurnov
fix typo envion e -> envrion
fcd3517
@yurnov
attemp to fix linter
9ee8385
@yurnov
temprarly commit to test ansible-network/github_actions/pull/162
10b8525 
to be reverted
@yurnov
fix sanity test with ansible-core 2.18 and 2.19
c4795f5
@yurnov
revert back ignore-2.14.txt that should not be changed
bbd760c
@yurnov
Revert "temprarly commit to test ansible-network/github_actions/pull/162
1ac828d 
"

This reverts commit 9249d9a.
@yurnov
apply code-review suggestion from @abikouo
260574d
@yurnov
fix typo
b575608
@yurnov
fix typo
fd8abed
@yurnov
Initial commit with integration tests
b10f2ac
@yurnov
Fix integration tests
d8b9204
@yurnov
Fix linter in integration tests
0e580ba
@yurnov
Fix linter in integration tests
f638e65
@yurnov
Fix integration tests
756ce7e
@yurnov
another attempt to integration tests
bd00866
@yurnov
another attempt to integration tests
e0b3532
@yurnov
another attempt to integration tests
00e2525
@yurnov
Refactor integration test for kustomize environ support
61d950e
@yurnov
change version_added to 5.1.0
246773d
@yurnov yurnov force-pushed the support_local_env_for_kustomize branch from 0aa1db0 to 246773d Compare January 21, 2025 10:56
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/03dab435884949d4886fba302b07af66

✔️ ansible-galaxy-importer SUCCESS in 6m 12s
✔️ build-ansible-collection SUCCESS in 5m 47s

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/54934a88e5a24fe89d6cadb0cf574594

✔️ ansible-galaxy-importer SUCCESS in 2m 56s
✔️ build-ansible-collection SUCCESS in 5m 44s

@yurnov
bump version_added to 6.0.0
8360fb0 
no feature release planned in stable-5 branch
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/6ed6de0cf965427a9cb711d44bb6bf46

✔️ ansible-galaxy-importer SUCCESS in 3m 24s
✔️ build-ansible-collection SUCCESS in 5m 26s

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abikouo abikouo Awaiting requested review from abikouo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yurnov @abikouo