Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drop python 2 support (breaking changes) #86

Merged
merged 4 commits into from
May 4, 2021

Conversation

abikouo
Copy link
Contributor

@abikouo abikouo commented Apr 27, 2021

SUMMARY

Drop python 2 support for this collection.

@codecov
Copy link

codecov bot commented Apr 27, 2021

Codecov Report

Merging #86 (75d77d3) into main (8b2d39d) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #86   +/-   ##
=======================================
  Coverage   24.02%   24.02%           
=======================================
  Files           1        1           
  Lines         154      154           
  Branches       29       29           
=======================================
  Hits           37       37           
- Misses        111      112    +1     
+ Partials        6        5    -1     
Impacted Files Coverage Δ
...ections/kubernetes/core/plugins/action/k8s_info.py 24.02% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8b2d39d...75d77d3. Read the comment docs.

@abikouo abikouo changed the title drop python 2 support drop python 2 support (breaking changes) Apr 27, 2021
Copy link
Member

@gravesm gravesm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like you missed one in the requirements section of plugins/lookup/k8s.py

changelogs/fragments/86_drop_python2_support.yaml Outdated Show resolved Hide resolved
Co-authored-by: Mike Graves <mgraves@redhat.com>
@abikouo abikouo requested a review from gravesm April 30, 2021 15:50
@gravesm
Copy link
Member

gravesm commented May 3, 2021

plugins/lookup/k8s.py still shows a python 2.7 requirement.

@abikouo abikouo merged commit fc80540 into ansible-collections:main May 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants