Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Post release 5.1.0 update #866

Merged

Conversation

yurnov
Copy link
Contributor

@yurnov yurnov commented Jan 20, 2025

SUMMARY

This is a post-5.1.0 documentation update of the main branch that includes a cherry-pic of the changelog and an update version to 5.2.0-dev0.

ISSUE TYPE
  • Docs Pull Request
COMPONENT NAME
  • changelog
  • galaxy.yml
ADDITIONAL INFORMATION

The reason for this version bump is to understand of version when the collection is installed as ansible-galaxy collection install git+https://github.com/ansible-collections/kubernetes.core.git and don't mess up the main (that may contain some PRs that is not included to any released version) with the released version 5.1.0.

@yurnov yurnov mentioned this pull request Jan 20, 2025
32 tasks
Copy link

@@ -1,5 +1,5 @@
# Also needs to be updated in galaxy.yml
VERSION = 5.0.0
VERSION = 5.2.0-dev0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should make this 6.0.0-dev0 since we won't be doing any 5.x releases off of main.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should make this 6.0.0-dev0 since we won't be doing any 5.x releases off of main.

It cause a linter error, please find my separate comment with details and proposed way forward

@@ -25,7 +25,7 @@ tags:
- openshift
- okd
- cluster
version: 5.0.0
version: 5.2.0-dev0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Copy link

@yurnov
Copy link
Contributor Author

yurnov commented Jan 21, 2025

Oh,

update galaxy.yml to 6.0.0-dev0 lead to ansible-lint error:

ERROR: Found 1 pylint issue(s) which need to be resolved:
ERROR: plugins/inventory/k8s.py:166:8: collection-deprecated-version: Deprecated version ('6.0.0') found in call to Display.deprecated or AnsibleModule.deprecate

It's due to the deprecation of k8s inventory plugin:

plugin_routing:
  inventory:
    k8s:
      deprecation:
        removal_version: 6.0.0
        warning_text: >-
          The k8s inventory plugin has been deprecated and
          will be removed in release 6.0.0.

So, ansible lint doesn't allow 6.0.0-dev0 when the plugin deprecated in 6.0.0 is not removed.

I see the following way forward:
a. keep version 5.2.0-dev0 (or temporarily change to 5.1.0), and prepare a separate PR in near future with:

  • removing support of ansible.core<2.16.0;
  • removing deprecated k8s inventory plugin;
  • bump version to 6.0.0-dev0
    or
    b. forcefully merge this PR with 6.0.0-dev0 and immediately prepare separate PR with removing support of ansible.core<2.16.0 and k8s inventory plugin.

I can contribute in both cases.

@gravesm
Copy link
Member

gravesm commented Jan 21, 2025

We should go ahead and drop support for ansible <2.16 and remove the k8s_inventory plugin.

@yurnov
Copy link
Contributor Author

yurnov commented Jan 21, 2025

We should go ahead and drop support for ansible <2.16 and remove the k8s_inventory plugin.

Sure, but I think that is should be a separate PR with changelog.

@gravesm
Copy link
Member

gravesm commented Jan 21, 2025

Yeah, just use 5.2.0-dev on this PR and then we can get the other PRs done and bump the version to 6.0.0-dev

@yurnov
Copy link
Contributor Author

yurnov commented Jan 21, 2025

Yeah, just use 5.2.0-dev on this PR and then we can get the other PRs done and bump the version to 6.0.0-dev

Reverted last commit

Copy link

@yurnov
Copy link
Contributor Author

yurnov commented Jan 21, 2025

Thanks @gravesm!

Copy link

Build succeeded (gate pipeline).
https://ansible.softwarefactory-project.io/zuul/buildset/dc8c826b38314765872fcffc632fb08b

✔️ ansible-galaxy-importer SUCCESS in 6m 08s
✔️ build-ansible-collection SUCCESS in 5m 40s

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit 1943dfc into ansible-collections:main Jan 21, 2025
45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants