-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Post release 5.1.0 update #866
Post release 5.1.0 update #866
Conversation
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 4m 35s |
@@ -1,5 +1,5 @@ | |||
# Also needs to be updated in galaxy.yml | |||
VERSION = 5.0.0 | |||
VERSION = 5.2.0-dev0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should make this 6.0.0-dev0
since we won't be doing any 5.x releases off of main.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should make this
6.0.0-dev0
since we won't be doing any 5.x releases off of main.
It cause a linter error, please find my separate comment with details and proposed way forward
@@ -25,7 +25,7 @@ tags: | |||
- openshift | |||
- okd | |||
- cluster | |||
version: 5.0.0 | |||
version: 5.2.0-dev0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as above.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 3m 47s |
Oh, update
It's due to the deprecation of k8s inventory plugin:
So, ansible lint doesn't allow I see the following way forward:
I can contribute in both cases. |
We should go ahead and drop support for ansible <2.16 and remove the k8s_inventory plugin. |
Sure, but I think that is should be a separate PR with changelog. |
Yeah, just use 5.2.0-dev on this PR and then we can get the other PRs done and bump the version to 6.0.0-dev |
… planned" Please find ansible-collections#866 (comment) for reference This reverts commit 71606b2.
Reverted last commit |
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 4m 21s |
Thanks @gravesm! |
Build succeeded (gate pipeline). ✔️ ansible-galaxy-importer SUCCESS in 6m 08s |
1943dfc
into
ansible-collections:main
SUMMARY
This is a post-5.1.0 documentation update of the
main
branch that includes a cherry-pic of the changelog and an update version to5.2.0-dev0
.ISSUE TYPE
COMPONENT NAME
ADDITIONAL INFORMATION
The reason for this version bump is to understand of version when the collection is installed as
ansible-galaxy collection install git+https://github.com/ansible-collections/kubernetes.core.git
and don't mess up themain
(that may contain some PRs that is not included to any released version) with the released version 5.1.0.