Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes to enable the large_size_enabled option #182

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

FMFREAK040
Copy link

SUMMARY

Enabled the large_size_enabled option to enable the creation of large files (>16TB)

Fixes #181

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

na_ontap_volume.py

ADDITIONAL INFORMATION

To create a volume with the -is-large-size-enabled option set. There wasn't a way to to this with Ansbile. With the adds I commit you can use this option to set the -is-large-size-enabled option with Ansible.
This is necessary to let NetApp create LUN's of more than 16 TB and snapmirror them to another cluster.
When this option isn't set an you created an Snapshot of more that 16TB eg. at the initialization of the Snapmirror this will fail.

Copy link

codecov bot commented Nov 3, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (793e2ae) 91.64% compared to head (a27563a) 91.64%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #182      +/-   ##
==========================================
- Coverage   91.64%   91.64%   -0.01%     
==========================================
  Files         350      350              
  Lines       55651    55653       +2     
  Branches     7393     7394       +1     
==========================================
  Hits        51003    51003              
- Misses       2622     2623       +1     
- Partials     2026     2027       +1     
Files Coverage Δ
plugins/modules/na_ontap_volume.py 95.78% <0.00%> (-0.16%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@FMFREAK040
Copy link
Author

FMFREAK040 commented Nov 14, 2023

It looks like this tests will fail not on the commited code but on the ansible part, e.g.
ERROR: Package 'ansible-core' requires a different Python: 3.9.18 not in '>=3.10'

@FMFREAK040
Copy link
Author

Still want this commit to the code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Large size enabled not implemented
1 participant