Skip to content
This repository has been archived by the owner on May 28, 2024. It is now read-only.

Update checklist for post-inclusion recommendations #234

Closed
wants to merge 1 commit into from
Closed

Update checklist for post-inclusion recommendations #234

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions collection_checklist.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,3 +54,10 @@ Note for reviewers: If you don't know how to check the points below, please ask
- [ ] all CI tests MUST run against every pull request
- [ ] all CI tests MUST run regularly (nightly, or at least once per week)
- [ ] sanity tests MUST run against a commit that releases the collection; if they don't pass, the collection won't be released

**Steps to complete after inclusion is approved**
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added couple of points, thanks for pinging!


- [ ] Subscribe to the [news-for-maintainers](https://github.com/ansible-collections/news-for-maintainers) repo and track announcements there.
- [ ] Optionally but highly recommended, subscribe to the [Ansible Bullhorn](https://github.com/ansible/community/wiki/News#the-bullhorn). You can also post in the Bullhorn for community feedback or for important announcements such new releases of this collection.
- [ ] Review the [Maintainer guidelines](https://github.com/ansible/community-docs/blob/main/maintaining.rst).
- [ ] Optionally, share the above with future maintainers, in a README on CONTRIBUTING file in the collection repo.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this should be part of this checklist. This checklist is for reviewing only so far. Maybe we should add this as a separate file?

Copy link
Contributor

@Andersson007 Andersson007 Apr 23, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Adding as a separate file as @felixfontein suggested SGMT. I think it's worth to put a link to the end of the checklist as a reminder for reviewers to mention it as it's important
  • I wouldn't include the news-for-maintainers at least now
  • All the other links should be updated

Loading