Change URL for library item list in 7.0.3 spec #464
Conversation
When retrieving a list of items inside a content library, the URL was malformed due to a double key in the query. Spec 7.0.3 is changed to look like it did in 7.0.2.
|
Build succeeded. ✔️ ansible-test-cloud-integration-vmware-rest SUCCESS in 15m 23s |
|
This is weird. Those OpenAPI specs have been generated using vmware-openapi-generator: #449 It would be really interesting to know why this produced a buggy spec. |
|
@alinabuzachis This patch should immediately trigger |
|
Something else that falls into the "interesting to know" category, why didn't this fail in the CI: 🤔 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #464 +/- ##
==========================================
+ Coverage 34.15% 34.18% +0.02%
==========================================
Files 143 143
Lines 11055 11040 -15
Branches 2294 2291 -3
==========================================
- Hits 3776 3774 -2
+ Misses 7279 7266 -13
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Tests were disabled. |
|
@ephracis Can you please fix the linters issue in the changelog file? Once that is done we can merge this PR. |
I'm checking why the tests were disabled. I'll keep you updated. |
I'm not sure if this is really important. The important thing is to enable them again so the CI can help to keep the collection healthy ;-) I'm much more interested in the question why the spec I've generated was wrong. Maybe we should create an issue vmware-openapi-generator. Although I'm not sure if we would get an answer, it looks like it's dead... at least, there hasn't been a commit since 4 years. |
Absolutely! Pushed a fix now. |
|
Build succeeded. ✔️ ansible-test-cloud-integration-vmware-rest SUCCESS in 16m 30s |
|
Build succeeded (gate pipeline). ✔️ ansible-test-cloud-integration-vmware-rest SUCCESS in 14m 58s |
softwarefactory-project-zuul
bot
merged commit b757870
into
ansible-collections:main
Backport to stable-3: 💚 backport PR created✅ Backport PR branch: Backported as #486 🤖 @patchback |
Change URL for library item list in 7.0.3 spec SUMMARY When retrieving a list of items inside a content library, the URL was malformed due to a double key in the query. Spec 7.0.3 is changed to look like it did in 7.0.2. Fixes #463 ISSUE TYPE Bugfix Pull Request COMPONENT NAME content_library_item_info Reviewed-by: GomathiselviS Reviewed-by: Alina Buzachis (cherry picked from commit b757870)
[PR #464/b7578708 backport][stable-3] Change URL for library item list in 7.0.3 spec This is a backport of PR #464 as merged into main (b757870). SUMMARY When retrieving a list of items inside a content library, the URL was malformed due to a double key in the query. Spec 7.0.3 is changed to look like it did in 7.0.2. Fixes #463 ISSUE TYPE Bugfix Pull Request COMPONENT NAME content_library_item_info Reviewed-by: Ondra Machacek <machacek.ondra@gmail.com> Reviewed-by: Alina Buzachis
Change URL for library item list in 7.0.3 spec SUMMARY When retrieving a list of items inside a content library, the URL was malformed due to a double key in the query. Spec 7.0.3 is changed to look like it did in 7.0.2. Fixes ansible-collections#463 ISSUE TYPE Bugfix Pull Request COMPONENT NAME content_library_item_info Reviewed-by: GomathiselviS Reviewed-by: Alina Buzachis (cherry picked from commit b757870)
SUMMARY
When retrieving a list of items inside a content library, the URL was malformed due to a double key in the query. Spec 7.0.3 is changed to look like it did in 7.0.2.
Fixes #463
ISSUE TYPE
COMPONENT NAME
content_library_item_info