Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Testing with the new version of ansible-core 2.17 #492

Merged
merged 1 commit into from
Jun 2, 2024
Merged

Testing with the new version of ansible-core 2.17 #492

merged 1 commit into from
Jun 2, 2024

Conversation

bardielle
Copy link
Collaborator

SUMMARY

Update the sanity test to run with the new ansible-core version 2.17

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/607ba001dd504f4a9b8c7b3b4040ef46

✔️ build-ansible-collection SUCCESS in 12m 38s
✔️ tox-cloud-refresh-examples-vmware SUCCESS in 11m 06s
✔️ ansible-galaxy-importer SUCCESS in 5m 33s

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/560496044f6f4b469a15a30c3ec991fd

✔️ build-ansible-collection SUCCESS in 12m 14s
✔️ tox-cloud-refresh-examples-vmware SUCCESS in 11m 53s
✔️ ansible-galaxy-importer SUCCESS in 4m 00s

mariolenz
mariolenz approved these changes May 27, 2024
View reviewed changes
Copy link
Collaborator

@mariolenz mariolenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alinabuzachis
Copy link
Collaborator

@bardielle If you plan to release soon, you should also remove any support for ansible-core <2.14 since it has reached EOL. I would also remove it from the CI and update meta/runtime.yml and README to say that we are requiring ansible-core > 2.15 for this collection.

@bardielle
Copy link
Collaborator Author

bardielle commented May 27, 2024 •
edited
Loading

@alinabuzachis Thank you I will update it.
This change should sign with minor_changes or breaking_changes ?

@alinabuzachis
Copy link
Collaborator

@alinabuzachis Thank you I will update it. This change should sign with minor_changes or breaking_changes ?

It is a breaking_changes. So, it requires a major release.

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/eb5f8879e3fe4d8ba56e326ca66bef6b

✔️ build-ansible-collection SUCCESS in 11m 24s
✔️ tox-cloud-refresh-examples-vmware SUCCESS in 11m 25s
✔️ ansible-galaxy-importer SUCCESS in 5m 14s

@mariolenz
Copy link
Collaborator

Not to put too fine a point on this, but this collection is part of the Ansible community package (which is a good thing!). Therefor I'd like to suggest synchronizing major releases with this package.

Yes, dropping support for ansible-core 2.14 is a breaking change and requires a new major release. But Ansible 10.0.0 will be released soon and we already have a feature freeze. So we won't be able to get vmware.vmware_rest 4.0.0 into Ansible 10.

Please, please try to synchronize with the community package. The current stable release 9.x doesn't ship with the current release of this collection, because it's a major release and has been released shortly after Ansible 9.0.0. If you do a new major release, people using the community package will be stuck with an older version.

A good time to have a new major release would be October since Ansible 11 beta will probably have a feature freeze in November. Please consider this when doing major releases.

@bardielle
Copy link
Collaborator Author

bardielle commented May 28, 2024 •
edited
Loading

@mariolenz I think it's fine to release v4.0.0 on October- November.
I just want to make sure that it's fine to keep the support of 2.14 even if it was EOL.
@alisonlhart what do you think?

@alisonlhart
Copy link

Tagging in @chynasan so she can take a look

@bardielle
Copy link
Collaborator Author

bardielle commented May 28, 2024 •
edited
Loading

I asked @EmilyBock and she suggested splitting it into 2 releases
It is important to support the new version so we can release a minor release that includes that and later (in October/ November) we can release a major version
cc @alinabuzachis @mariolenz @alisonlhart

I opened that PR#495

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link
Contributor

Build failed (gate pipeline). For information on how to proceed, see
http://docs.openstack.org/infra/manual/developers.html#automated-testing

https://ansible.softwarefactory-project.io/zuul/buildset/3331fc4ebd074b6d9ff00017018676b6

✔️ build-ansible-collection SUCCESS in 14m 00s
✔️ tox-cloud-refresh-examples-vmware SUCCESS in 13m 08s
❌ ansible-galaxy-importer RETRY_LIMIT in 4m 29s

@bardielle
Copy link
Collaborator Author

recheck

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link
Contributor

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/6fb3f6352bd14e65867da16b38e16e95

✔️ build-ansible-collection SUCCESS in 14m 11s
✔️ tox-cloud-refresh-examples-vmware SUCCESS in 14m 47s
❌ ansible-galaxy-importer RETRY_LIMIT in 4m 20s

@bardielle
Copy link
Collaborator Author

@alinabuzachis I see that all the new PRs failing with the same dependency error

ERROR! Failed to resolve the requested dependencies map. Got the candidate cloud.common:5.0.0 (dependency of vmware.vmware_rest:4.0.0) which didn't satisfy all of the following requirements:
* cloud.common:5.0.0
* cloud.common:>=3.0.0,<4.0.0
Hint: Pre-releases hosted on Galaxy or Automation Hub are not installed by default unless a specific version is requested. To enable pre-releases globally, use --pre.
Starting galaxy collection install process
Process install dependency map

And in the galaxy.yml there is a dependency cloud.common: ">=3.0.0,<4.0.0" what is the reason for that? how can I solve it?

@alinabuzachis
Copy link
Collaborator

@alinabuzachis I see that all the new PRs failing with the same dependency error

ERROR! Failed to resolve the requested dependencies map. Got the candidate cloud.common:5.0.0 (dependency of vmware.vmware_rest:4.0.0) which didn't satisfy all of the following requirements:
* cloud.common:5.0.0
* cloud.common:>=3.0.0,<4.0.0
Hint: Pre-releases hosted on Galaxy or Automation Hub are not installed by default unless a specific version is requested. To enable pre-releases globally, use --pre.
Starting galaxy collection install process
Process install dependency map

And in the galaxy.yml there is a dependency cloud.common: ">=3.0.0,<4.0.0" what is the reason for that? how can I solve it?

I created this PR #496. We have released cloud.common 4.0.0 last week and the dependency version in the galaxy.yml file needs to be increased.

@bardielle
Copy link
Collaborator Author

@alinabuzachis thank you I wasn't aware.

@mikemorency mikemorency self-requested a review May 29, 2024 14:10
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link
Contributor

Build failed (gate pipeline). For information on how to proceed, see
http://docs.openstack.org/infra/manual/developers.html#automated-testing

https://ansible.softwarefactory-project.io/zuul/buildset/a5c54b7f47364851b0d5047106e1f440

✔️ build-ansible-collection SUCCESS in 14m 50s
✔️ tox-cloud-refresh-examples-vmware SUCCESS in 15m 30s
❌ ansible-galaxy-importer RETRY_LIMIT in 4m 36s

@mariolenz
Copy link
Collaborator

recheck

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link
Contributor

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/a5e66300ca8d47b7ba60c259b0685e8b

✔️ build-ansible-collection SUCCESS in 14m 11s
✔️ tox-cloud-refresh-examples-vmware SUCCESS in 14m 57s
❌ ansible-galaxy-importer RETRY_LIMIT in 4m 39s

@bardielle
Copy link
Collaborator Author

recheck

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/e5c88f14f39e45dc9b4ea1a928db4bd5

✔️ build-ansible-collection SUCCESS in 16m 36s
✔️ tox-cloud-refresh-examples-vmware SUCCESS in 17m 08s
✔️ ansible-galaxy-importer SUCCESS in 5m 00s

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).
https://ansible.softwarefactory-project.io/zuul/buildset/38cbdd2ec1ee4098b41aea25a5133f63

✔️ build-ansible-collection SUCCESS in 11m 38s
✔️ tox-cloud-refresh-examples-vmware SUCCESS in 12m 13s
✔️ ansible-galaxy-importer SUCCESS in 3m 50s

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link
Contributor

Pull request merge failed: Resource not accessible by integration, You may need to manually rebase your PR and retry.

@bardielle bardielle merged commit 31ef977 into ansible-collections:main Jun 2, 2024
18 checks passed
mikemorency pushed a commit to mikemorency/vmware.vmware_rest that referenced this pull request Aug 16, 2024
@bardielle @mikemorency
Testing with the new version of ansible-core 2.17 (ansible-collection…
3a603a4 
…s#492)

(cherry picked from commit 31ef977)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alinabuzachis alinabuzachis alinabuzachis approved these changes

@mikemorency mikemorency mikemorency approved these changes

@machacekondra machacekondra machacekondra approved these changes

@mariolenz mariolenz mariolenz approved these changes

Assignees
No one assigned
Labels
mergeit
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@bardielle @alinabuzachis @mariolenz @alisonlhart @machacekondra @mikemorency