Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding better documentation for the customization module #534

Conversation

mikemorency
Copy link
Collaborator

@mikemorency mikemorency commented Sep 25, 2024

SUMMARY

Updates the examples in the vm customization module to be more detailed and cover both the linux and cloud-init configuration schemes.

Fixes
#472
#527

ISSUE TYPE
  • Docs Pull Request
COMPONENT NAME

vcenter_vm_guest_customization

Copy link

codecov bot commented Sep 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 37.04%. Comparing base (a9a257f) to head (0cb44d6).
Report is 9 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #534      +/-   ##
==========================================
+ Coverage   36.58%   37.04%   +0.46%     
==========================================
  Files         145      145              
  Lines       11549    11388     -161     
  Branches     2301     2258      -43     
==========================================
- Hits         4225     4219       -6     
+ Misses       7324     7169     -155     
Flag Coverage Δ
sanity 37.04% <ø> (+0.46%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mikemorency mikemorency force-pushed the feature/add-better-customization-examples branch from 1792a2b to 0cb44d6 Compare September 25, 2024 17:09
Copy link
Contributor

Copy link
Contributor

Build succeeded (gate pipeline).
https://ansible.softwarefactory-project.io/zuul/buildset/836363a2a9db45399e8602a0e69cffc6

✔️ ansible-test-cloud-integration-vmware-rest SUCCESS in 10m 59s
✔️ build-ansible-collection SUCCESS in 7m 51s
✔️ ansible-galaxy-importer SUCCESS in 6m 32s

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit e199529 into ansible-collections:main Sep 30, 2024
14 checks passed
@sean-freeman
Copy link

@mikemorency @bardielle This PR takes my provided code in #471 for cloud-init, but does not fix #471 and therefore is documenting a procedure that cannot possibly work for any end-user. It should be removed from the Ansible Collection documentation until the procedure is confirmed working.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants