Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add eco vcenter upstream ci capabilities #538

Conversation

shellymiron
Copy link
Collaborator

SUMMARY

This PR aims to insert self hosted runner to enable integration tests to run on the eco vcenter environment.
This includes several adjustments to the code and additional action to be triggered for each PR, and run all the
integration tests on that env with the PR's new code.

Copy link

codecov bot commented Oct 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 37.04%. Comparing base (91ce77b) to head (52e3779).
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #538   +/-   ##
=======================================
  Coverage   37.04%   37.04%           
=======================================
  Files         145      145           
  Lines       11388    11388           
  Branches     2258     2258           
=======================================
  Hits         4219     4219           
  Misses       7169     7169           
Flag Coverage Δ
sanity 37.04% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@mikemorency
Copy link
Collaborator

the mergeit label will try to merge the pr AFAIK. it should be added once someone reviews

@shellymiron shellymiron force-pushed the add_eco_ci_action branch 2 times, most recently from 78ca83c to 33dc953 Compare October 13, 2024 07:27
Copy link
Contributor

@shellymiron shellymiron force-pushed the add_eco_ci_action branch 18 times, most recently from 4cd209a to 5404344 Compare October 13, 2024 09:48
Copy link
Contributor

Copy link
Contributor

Copy link
Contributor

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/a35e3ba72d354bc5b3f87a60677d903a

⚠️ ansible-test-cloud-integration-vmware-rest SKIPPED Skipped due to failed job build-ansible-collection
build-ansible-collection NODE_FAILURE Node request 200-0007623629 failed in 0s
⚠️ ansible-galaxy-importer SKIPPED Skipped due to failed job build-ansible-collection

Copy link
Contributor

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/764d4fccf8174387a13292aa031aaa9a

⚠️ ansible-test-cloud-integration-vmware-rest SKIPPED Skipped due to failed job build-ansible-collection
build-ansible-collection NODE_FAILURE Node request 200-0007623638 failed in 0s
⚠️ ansible-galaxy-importer SKIPPED Skipped due to failed job build-ansible-collection

Copy link
Contributor

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/b54a1b0f136947b58d928e0130416465

⚠️ ansible-test-cloud-integration-vmware-rest SKIPPED Skipped due to failed job build-ansible-collection
build-ansible-collection NODE_FAILURE Node request 200-0007623639 failed in 0s
⚠️ ansible-galaxy-importer SKIPPED Skipped due to failed job build-ansible-collection

Copy link
Contributor

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/7a11208b45d1471291c45c07e6446b7e

⚠️ ansible-test-cloud-integration-vmware-rest SKIPPED Skipped due to failed job build-ansible-collection
build-ansible-collection NODE_FAILURE Node request 200-0007623640 failed in 0s
⚠️ ansible-galaxy-importer SKIPPED Skipped due to failed job build-ansible-collection

Copy link
Contributor

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/bc59b27549cb410c89f30f97f4eca9bb

⚠️ ansible-test-cloud-integration-vmware-rest SKIPPED Skipped due to failed job build-ansible-collection
build-ansible-collection NODE_FAILURE Node request 200-0007623641 failed in 0s
⚠️ ansible-galaxy-importer SKIPPED Skipped due to failed job build-ansible-collection

Copy link
Contributor

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/47a8bb3920414f69bf2e95745b08fb36

⚠️ ansible-test-cloud-integration-vmware-rest SKIPPED Skipped due to failed job build-ansible-collection
build-ansible-collection NODE_FAILURE Node request 200-0007623642 failed in 0s
⚠️ ansible-galaxy-importer SKIPPED Skipped due to failed job build-ansible-collection

Copy link
Contributor

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/6b44778365604a27b13183fbdbe06198

⚠️ ansible-test-cloud-integration-vmware-rest SKIPPED Skipped due to failed job build-ansible-collection
build-ansible-collection NODE_FAILURE Node request 200-0007623643 failed in 0s
⚠️ ansible-galaxy-importer SKIPPED Skipped due to failed job build-ansible-collection

@shellymiron
Copy link
Collaborator Author

recheck

@shellymiron shellymiron marked this pull request as ready for review October 27, 2024 06:52
@shellymiron shellymiron force-pushed the add_eco_ci_action branch 2 times, most recently from 08da4e1 to 8479dfa Compare October 27, 2024 07:02
@shellymiron
Copy link
Collaborator Author

@anna-savina @mikemorency hey! please review :) this PR insert the eco ci job capabilities without editing a specific integration test - once a PR to adjust a test will be open, the job will catch it and run it by the the prefix of the test - vmware_rest

Copy link
Contributor

@mikemorency
Copy link
Collaborator

I was thinking that the test env will need to install the requirements.txt in the root of the repo. But then I looked at vmware.vmware and it doesnt look like we install any python requirements for those tests. So Im not really sure how it works but I guess we dont need to install anything extra for these tests too?

@shellymiron
Copy link
Collaborator Author

@mikemorency yeah I looked at it aswell and assumed we don't need to install any requirements - worst case scenario is to add it later as a step in the Makefile if we will need it for the tests

Copy link
Collaborator

@anna-savina anna-savina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

Build succeeded (gate pipeline).
https://ansible.softwarefactory-project.io/zuul/buildset/ccc4700ed50244509c8bd0a8cf9197f7

✔️ ansible-test-cloud-integration-vmware-rest SUCCESS in 12m 52s
✔️ build-ansible-collection SUCCESS in 7m 16s
✔️ ansible-galaxy-importer SUCCESS in 4m 43s

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit d1b5e83 into ansible-collections:main Oct 28, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants