Feat: AnsibleVarsParser

[quietjoy]

Closes #110

This is a work in progress PR to attempt to allow ansible_bender variables to be specified across group and host var files.

[TomasTomecek]

wow, this looks solid! thank you for the detailed test cases

[quietjoy]

Hi @TomasTomecek - any idea what the problem with CI is?

Tests are passing for me with the command: WITH_TESTS=yes vagrant up --provision

I can look into it later if you don't have enough time. I need some time to get more familar with packit.

I will also add some additional documentation for the new variables as well. Documentation added in 1ba394b

[TomasTomecek]

/usr/bin/python3: No module named pip

in the flood of tracebacks and errors of the build logs: let me fix that

[TomasTomecek]

please rebase :)

[TomasTomecek]

I can see one test failure:

=================================== FAILURES ===================================
___________________ test_can_specify_playbook_and_inventory ____________________

    def test_can_specify_playbook_and_inventory():
        playbook_path = "tests/data/projects/playbook_and_inventory/playbook.yml"
        inventory_path = "tests/data/projects/playbook_and_inventory/hosts.ini"
        vars_parser = AnsibleVarsParser(playbook_path, inventory_path)
    
        build, metadata = vars_parser.get_build_and_metadata()
    
        assert build.base_image == "docker.io/python:3-alpine"
        assert build.target_image == "a-very-nice-image"
>       assert len(build.build_volumes) == 1
E       assert 0 == 1
E        +  where 0 = len([])
E        +    where [] = <ansible_bender.conf.Build object at 0x7fb95804d110>.build_volumes

build      = <ansible_bender.conf.Build object at 0x7fb95804d110>
inventory_path = 'tests/data/projects/playbook_and_inventory/hosts.ini'
metadata   = <ansible_bender.conf.ImageMetadata object at 0x7fb9579cf050>
playbook_path = 'tests/data/projects/playbook_and_inventory/playbook.yml'
vars_parser = <ansible_bender.core.AnsibleVarsParser object at 0x7fb95729fa50>

tests/integration/test_core.py:29: AssertionError

is this related to your change?

[quietjoy]

I can see one test failure:
is this related to your change?

@TomasTomecek - it is. I will look into it

[quietjoy]

Hmm...latest test failure is for FAILED tests/functional/test_buildah.py::test_two_runs. I have not seen this failure before. Will need some time to dig in

ERROR  Error: crun: executable file `true` not found in $PATH: No such file or directory: OCI runtime attempted to invoke a command that was not found
Error: crun: executable file `true` not found in $PATH: No such file or directory: OCI runtime attempted to invoke a command that was not found
There was an error during execution: Command '['podman', 'run', '--rm', 'quay.io/biocontainers/python:3', 'true']' returned non-zero exit status 127.

[TomasTomecek]

looks like a bug in podman to me:

$ podman run quay.io/biocontainers/python:3 ls -lha /bin/true
lrwxrwxrwx    1 root     root           7 May 23  2014 /bin/true -> busybox

true is available as /bin/true

also tests pass on all the stable fedora versions; I'm in favour of merging :)

btw I will be away on a vacation for one week, once I'm back I'd finally love to do a new release with this change to get feedback from the community

[quietjoy]

@TomasTomecek - I am unable to replicate on my machine with WITH_TESTS=yes vagrant up --provision. I'm in favor of merging if you are.

After this merges, I am planning on putting together a small demo project that demonstrates how to use some of these new features.

Looking forward to the next release!

[TomasTomecek]

oki, let's merge, happy weekend!