Use StrPath; fix collection missing error reporting.

ansible-community · Aug 29, 2024 · ed72585 · ed72585
1 parent 4d0d6fe
commit ed72585
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/src/antsibull/collection_meta.py b/src/antsibull/collection_meta.py
@@ -20,6 +20,9 @@
 from pydantic.functional_validators import BeforeValidator
 from typing_extensions import Annotated
 
+if t.TYPE_CHECKING:
+    from _typeshed import StrPath
+
 
 def _convert_pypi_version(v: t.Any) -> t.Any:
     if not isinstance(v, str):
@@ -80,7 +83,7 @@ class CollectionsMetadata(p.BaseModel):
     collections: dict[str, CollectionMetadata]
 
     @staticmethod
-    def load_from(deps_dir: str | None):
+    def load_from(deps_dir: StrPath | None):
         if deps_dir is None:
             return CollectionsMetadata(collections={})
         collection_meta_path = os.path.join(deps_dir, "collection-meta.yaml")

diff --git a/src/antsibull/collection_meta_lint.py b/src/antsibull/collection_meta_lint.py
@@ -162,7 +162,7 @@ def validate(self, data: CollectionsMetadata) -> None:
 
         # Complain about remaining collections
         for collection in sorted(remaining_collections):
-            print(f"collections: No metadata present for {collection}")
+            self.errors.append(f"collections: No metadata present for {collection}")
 
 
 def lint_collection_meta() -> int: