-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Faster docs extraction #197
Faster docs extraction #197
Conversation
venv_python = venv.get_command('python') | ||
|
||
with tempfile.NamedTemporaryFile() as tmp_file: | ||
tmp_file.write(get_antsibull_data('collection-enum.py')) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was thinking we should have this run in-process instead of being a separate, internal script. Is that something we can do? Is the dependence on ansible-base code the reason it was easier to write this as a separate script at first?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the stable
subcommand, we really must run it in the venv, otherwise it does not necessarily have access to the correct ansible-base version. (For the current
subcommand it doesn't matter.)
This includes the changes from #206 that don't modify the output. It also contains one commit which repliaces ansible/ansible#72359's behavior for the new extraction backend. |
…ections and plugin docs.
7128f90
to
4492666
Compare
Thanks felixfontein! This will be very appreciated by everyone :-) |
@abadger thanks again for reviewing! :) |
Uses a script to efficiently extract documentation. For my local set of collections,
antsibull-docs current --dest-dir ...
finishes in 25 seconds (!).