-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix sphinx-init --fail-on-error trailing backslash #409
fix sphinx-init --fail-on-error trailing backslash #409
Conversation
Code looks good, but can you please add a changelog fragment? Thanks :) |
Co-authored-by: Felix Fontein <felix@fontein.de>
@briantist thanks for fixing this! |
@felixfontein thanks! please let know when this change is released, have a few things in flight that will need this 😀 |
I was thinking of waiting for a run of the test docsite build (for ansible/ansible#77362). I hope that can happen tomorrow... |
Sounds good to me, not a huge rush, a comment here or a ping on IRC when it's released would be great if you remember 🙏 |
@briantist I just released 0.42.1 with this fix. |
I found that using
--fail-on-error
withsphinx-init
resulted in a brokenbuild.sh
due to a missing trailing backslash.Example: