Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix boolean error in warning; error out if only one of --version and --codename is supplied for an ansible-core release #105

Merged
merged 3 commits into from
Mar 13, 2023
Merged

Fix boolean error in warning; error out if only one of --version and --codename is supplied for an ansible-core release #105

merged 3 commits into from
Mar 13, 2023

Conversation

felixfontein
Copy link
Collaborator

Improves the situation for #104 a bit.

@felixfontein felixfontein mentioned this pull request Mar 11, 2023
Open
gotmax23
gotmax23 approved these changes Mar 13, 2023
View reviewed changes
Copy link
Contributor

@gotmax23 gotmax23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ack

@gotmax23 gotmax23 merged commit 2451c2d into ansible-community:main Mar 13, 2023
@gotmax23
Copy link
Contributor

Thanks @felixfontein and @briantist!

@felixfontein felixfontein deleted the fixes branch March 13, 2023 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gotmax23 gotmax23 gotmax23 approved these changes

@briantist briantist briantist approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@felixfontein @gotmax23 @briantist