Support semantic markup for roles #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gotmax23
reviewed
Mar 26, 2023
| if idx >= 0: | ||
| entrypoint = text[:idx] | ||
| text = text[idx + 1 :] | ||
| if entrypoint is None: |
There was a problem hiding this comment.
Should this be
Suggested change
| if entrypoint is None: | |
| if not entrypoint: |
? I assume you'd also want a value like :abc (text[:idx] would be an empty string) to cause an error.
There was a problem hiding this comment.
I don't know whether ansible-core allows empty entrypoints. (Considering how flexible roles are in general, I wouldn't be surprised if it does.)
There was a problem hiding this comment.
I'm going to merge this as-is for now. If it turns out that ansible-core does not allow these we can stricten the parsing rules later.
Co-authored-by: Maxwell G <maxwell@gtmx.me>
|
@gotmax23 thanks for reviewing this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements proposal from ansible-community/antsibull-docs#113.