Enable darglint via pre-commit #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cidrblock
requested review from
a team,
ssbarnea,
priyamsahoo,
shatakshiiii and
rndmh3ro
and removed request for
a team
|
TBH, considering astral-sh/ruff#458 I am more inclined to see ruff enablement as the easier path. |
|
yeah, I turned on ruff last week, a couple exceptions to deal with. I can't wait for darglint support in ruff... |
ssbarnea
approved these changes
Apr 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additionally add a darglint config file
Note, only use the darglint pre-commit hook until such time ruff supports these rules. It is WIP for ruff.