Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ui: upgrade from bootstrap 4 to bootstrap 5 #339

Open
dmsimard opened this issue Nov 20, 2021 · 1 comment
Open

ui: upgrade from bootstrap 4 to bootstrap 5 #339

dmsimard opened this issue Nov 20, 2021 · 1 comment
Labels
UI Related to the built-in user interface

Comments

@dmsimard
Copy link
Contributor

dmsimard commented Nov 20, 2021 •
edited
Loading

What is the idea ?

One of the vendored static asset for the reporting UI is bootstrap via bootswatch themes: https://github.com/ansible-community/ara/tree/master/ara/ui/static

Unfortunately, bootstrap 5 was still in beta (or alpha?) when the last UI refresh was done and so I picked bootstrap 4 to do it at the time.

bootstrap 5 as well as the bootswatch themes are available now, providing an opportunity to update them.

bootstrap 5 says it doesn't need jquery anymore but I'm not 100% sure we don't use it elsewhere. If it turns out we don't need it we can remove it.
@dmsimard dmsimard added the UI Related to the built-in user interface label Nov 20, 2021
@dmsimard
Copy link
Contributor Author

I've created a PR to see what it looks like: #340

@dmsimard dmsimard added this to the 1.5.8 milestone Jan 3, 2022
@dmsimard dmsimard mentioned this issue Mar 19, 2022
Merged
@dmsimard dmsimard removed this from the 1.5.8 milestone Mar 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
UI Related to the built-in user interface
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dmsimard