Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

requirements: update django to 3.2 LTS #360

Merged
merged 1 commit into from
Apr 1, 2022
Merged

requirements: update django to 3.2 LTS #360

merged 1 commit into from
Apr 1, 2022

Conversation

dmsimard
Copy link
Contributor

We've been recommending django 2.2 LTS and now that 3.2 has been out for
almost a year, we should bump the requirement.

@dmsimard
Copy link
Contributor Author

I am cautiously optimistic but unless mistaken, it seems like it just works ?
I didn't test exhaustively but the server and interface seem to run fine as well as recording a playbook locally.

@softwarefactory-project-zuul
Copy link

Build failed.

@dmsimard dmsimard force-pushed the update-django branch 3 times, most recently from c43bca4 to 73d1411 Compare February 28, 2022 17:06
@dmsimard
Copy link
Contributor Author

Should be OK now I think but it would need to be rebased on top of #361 once it merges due to an unrelated failing linter test.

This is probably a significant enough change to warrant leaving it out of 1.5.8 (which is already long overdue) but it should otherwise be good to land.

@dmsimard dmsimard mentioned this pull request Feb 28, 2022
Open
@softwarefactory-project-zuul
Copy link

Build failed.

@softwarefactory-project-zuul
Copy link

Build succeeded.

@dmsimard dmsimard marked this pull request as draft March 1, 2022 15:39
@dmsimard
Copy link
Contributor Author

recheck

@dmsimard
Copy link
Contributor Author

Should be OK now I think but it would need to be rebased on top of #361 once it merges due to an unrelated failing linter test.

This is probably a significant enough change to warrant leaving it out of 1.5.8 (which is already long overdue) but it should otherwise be good to land.

CI fixes have been done.

Let's keep this for another version bump, it would be a good fit to include with the update from bootstrap 4 to bootstrap 5: #339

@dmsimard dmsimard mentioned this pull request Mar 19, 2022
Merged
@dmsimard
Copy link
Contributor Author

dmsimard commented Mar 19, 2022 •
edited
Loading

Just noticed, we shouldn't forget about updating the documentation links to point to django 3.2 instead of 2.2: https://raw.githubusercontent.com/ansible-community/ara/master/doc/source/api-configuration.rst

.. _CORS_ORIGIN_WHITELIST: https://github.com/adamchainz/django-cors-headers#cors_origin_whitelist
.. _CORS_ORIGIN_REGEX_WHITELIST: https://github.com/adamchainz/django-cors-headers#cors_origin_regex_whitelist
.. _ALLOWED_HOSTS: https://docs.djangoproject.com/en/2.2/ref/settings/#allowed-hosts
.. _DEBUG: https://docs.djangoproject.com/en/2.2/ref/settings/#std:setting-DEBUG
.. _SECRET_KEY: https://docs.djangoproject.com/en/2.2/ref/settings/#std:setting-SECRET_KEY
.. _TIME_ZONE: https://docs.djangoproject.com/en/2.2/ref/settings/#std:setting-TIME_ZONE
.. _ENGINE: https://docs.djangoproject.com/en/2.2/ref/settings/#engine
.. _NAME: https://docs.djangoproject.com/en/2.2/ref/settings/#name
.. _USER: https://docs.djangoproject.com/en/2.2/ref/settings/#user
.. _PASSWORD: https://docs.djangoproject.com/en/2.2/ref/settings/#password
.. _HOST: https://docs.djangoproject.com/en/2.2/ref/settings/#host
.. _PORT: https://docs.djangoproject.com/en/2.2/ref/settings/#port
.. _CONN_MAX_AGE: https://docs.djangoproject.com/en/2.2/ref/settings/#conn-max-age
.. _OPTIONS: https://docs.djangoproject.com/en/2.2/ref/settings/#std:setting-OPTIONS

@softwarefactory-project-zuul
Copy link

Build succeeded.

@dmsimard dmsimard mentioned this pull request Mar 20, 2022
Closed
@dmsimard
requirements: update django to 3.2 LTS
30f0213 
We've been recommending django 2.2 LTS and now that 3.2 has been out for
almost a year, we should bump the requirement.
@softwarefactory-project-zuul
Copy link

Build succeeded.

@dmsimard dmsimard marked this pull request as ready for review April 1, 2022 17:47
@dmsimard dmsimard merged commit ac9ceff into ansible-community:master Apr 1, 2022
@dmsimard dmsimard mentioned this pull request Aug 11, 2022
Open
@dmsimard dmsimard mentioned this pull request Apr 7, 2023
Closed
@dmsimard dmsimard mentioned this pull request Aug 10, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@dmsimard