Openstack add public IP options #263
Open
+14
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apatard
reviewed
Dec 20, 2024
| @@ -102,6 +102,8 @@ | |||
| image: "{{ item.image }}" | |||
| key_name: "{{ key_name }}" | |||
| flavor: "{{ item.flavor }}" | |||
| floating_ip_pools: "{{ item.floating_ip_pools if item.floating_ip_pools is defined and item.floating_ip_pools else omit }}" | |||
There was a problem hiding this comment.
why not checking with | length > 0 ?
There was a problem hiding this comment.
Are you suggesting item.floating_ip_pools is defined and item.floating_ip_pools | length > 0?
What is the benefit opposed to the current state?
There was a problem hiding this comment.
Yes, I was suggesting something like that. I prefer '| length > 0' because it's more explicit. I'm not sure what's the current practice in the repo but I guess it was to using that and that's what matters (rather than my opinion).
I also was expecting ansible-lint to complain about it but I've not checked it.
audgirka
force-pushed
the
openstack-add-public-ip-options
branch
from
a68921a to
82111c2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds options to the OpenStack plugin to set a list of floating IP pools from which to choose a floating IP or to turn off the allocation of a public IP.
Supersedes #229 and #243