Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing quote line 207 of cis_5.3.x.yml #292

Closed
mballon opened this issue May 23, 2022 · 1 comment
Closed

Missing quote line 207 of cis_5.3.x.yml #292

mballon opened this issue May 23, 2022 · 1 comment
Labels

Comments

@mballon
Copy link

mballon commented May 23, 2022

Describe the Issue
Missing quote line 207 of cis_5.3.x.yml

Expected Behavior
Line should start with quote or have no quote at the end. I don't see why you're matching the commented line either, although that's just my opinion.

Actual Behavior
This regex is not matching causing the line "HostbasedAuthentication no" to be added every time the tasks is run.

Control(s) Affected
What controls are being affected by the issue

Environment (please complete the following information):

  • Ansible Version: 2.9
  • Host Python Version: Python 2.7.5
  • Ansible Server Python Version: Python 3.6.8
  • Additional Details:

Additional Notes
Example result of current version:

grep ^HostbasedAuthentication /etc/ssh/sshd_config

HostbasedAuthentication no
HostbasedAuthentication no
HostbasedAuthentication no
HostbasedAuthentication no
HostbasedAuthentication no

Possible Solution
According to Anisble Module Doc a single quote on either end of the line or no quotes is the correct syntax. I test both and agree.

@mballon mballon added the bug label May 23, 2022
georgenalen added a commit that referenced this issue May 23, 2022
Signed-off-by: George Nalen <georgen@mindpointgroup.com>
@georgenalen
Copy link
Contributor

@mballon,
Thanks for the issue, I have the fix in a new branch and PR process going.

-George

georgenalen added a commit that referenced this issue May 25, 2022
basharatoum pushed a commit to basharatoum/RHEL7-CIS that referenced this issue Jun 9, 2022
Signed-off-by: George Nalen <georgen@mindpointgroup.com>
Signed-off-by: Bashar Al atoum <basharatoum@Bashars-MacBook-Pro.local>
@mballon mballon closed this as completed Jul 26, 2022
uk-bolly pushed a commit that referenced this issue Aug 3, 2022
Signed-off-by: George Nalen <georgen@mindpointgroup.com>
Signed-off-by: Mark Bolwell <mark.bollyuk@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants