fixes an issue with using the extend directive with a loop #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change addresses a problem that would effectively cause the directive to ignore the extend keyword when the export value is a looped. In that case, the return fact would be registered to the top level key not the extended one. This change addresses that issue such that extend is honored during fact expansion
|
Build succeeded.
|
trishnaguha
approved these changes
Jul 2, 2018
|
recheck |
|
Build succeeded.
|
|
Build succeeded (gate pipeline).
|
|
Merge Failed. This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset. |
|
Checked "Allow merge commits" and removed |
gundalow
approved these changes
Jul 2, 2018
|
Build succeeded (gate pipeline).
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change addresses a problem that would effectively cause the
directive to ignore the extend keyword when the export value is a
looped. In that case, the return fact would be registered to the top
level key not the extended one. This change addresses that issue such
that extend is honored during fact expansion