Fix native type conversion in json_template #154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ganeshrn
changed the title
Fixes ansible-network#151 * The current implementation tries to convert the value to int irrespective to the actual desired type of data. * Ansible version 2.7 onwards supports native jinja2 types eg: value: "{{ item.name.acl_name|float }}" To convert to native jinja2 type by default need to set `jinja2_native` config varaible in `defaults` setion within configuration file. Note: this required jinja2 version to be >= 2.10
ganeshrn
force-pushed
the
json_template_value_fix
branch
from
ab2b443 to
af60ec2
Compare
|
Build failed.
|
|
Build succeeded.
|
trishnaguha
approved these changes
Oct 8, 2018
|
@ganeshrn We need to put this in Doc that this feature is only supported with Ansible 2.7 and requires jinja2 version to be >= 2.10. This cannot be backported. |
|
Build failed.
|
trishnaguha
reviewed
Oct 9, 2018
docs/directives/parser_directives.md
Outdated
|
|
||
| **Note** | ||
| Native jinja2 datatype (eg. 'int', 'float' etc.) rendering is supported with Ansible version >= 2.7 | ||
| and jinja2 library version >= 2.10 |
There was a problem hiding this comment.
Can you please add an example?
|
Build failed.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #151
The current
json_templateimplementation tries to convert the value to int irrespective to theactual type of data.
Ansible version 2.7 onwards supports native jinja2 types conversion. Refer JSON templating incorrectly changes the value to type int #151 (comment)
eg: value: "{{ item.name.acl_name|float }}"To convert to native jinja2 type by default need to set
jinja2_nativeconfig varaible indefaultssection of active Ansible config file.
Note: This feature require jinja2 version to be >= 2.10