Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify scripts/check_galaxy to return more descriptive error message(s) #695

Merged
merged 11 commits into from
Aug 15, 2024
Merged

Modify scripts/check_galaxy to return more descriptive error message(s) #695

Changes from 3 commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
2e6af2c
Check for ansible-galaxy presence and basic functionality in check_ga…
brookelew Jul 24, 2024
647b64b
Specify that user debugging for ansible-galaxy problems in execution …
brookelew Jul 24, 2024
44cac5b
Fix syntax error
brookelew Jul 24, 2024
45d709d
Make check_galaxy script use a single test.
brookelew Jul 25, 2024
e92cb25
Merge branch 'ansible:devel' into devel
brookelew Jul 31, 2024
78d6a55
Trial check_galaxy integration test
brookelew Jul 31, 2024
1a5bf0a
Finalize check_galaxy integration test
brookelew Jul 31, 2024
b79ed6d
Fix wrong name for copied file
brookelew Jul 31, 2024
ebba710
Implement requested changes from review
brookelew Jul 31, 2024
3aed183
Fix lint warning and modify bad-ansible.cfg to give a parse error
brookelew Aug 7, 2024
e76c0ec
Actual parse error from bad ansible.cfg
brookelew Aug 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 19 additions & 1 deletion src/ansible_builder/_target_scripts/check_galaxy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@

set -x

ansible-galaxy --version
command -v ansible-galaxy

if [ $? -ne 0 ]
then
Expand All @@ -43,4 +43,22 @@ EOF
exit 1
fi

ansible-galaxy --version

if [ $? -ne 0 ]
then
cat<<EOF
**********************************************************************
ERROR - 'ansible-galaxy' not functioning as expected

'ansible-galaxy' is installed, but running it returns an error.

For more information, you can try adding 'ansible-galaxy --version'
to 'prepend_galaxy' in 'additional_build_steps' and observing
the output.
**********************************************************************
EOF
exit 1
fi

exit 0
Loading