-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modify scripts/check_galaxy to return more descriptive error message(s) #695
Merged
Merged
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
2e6af2c
Check for ansible-galaxy presence and basic functionality in check_ga…
brookelew 647b64b
Specify that user debugging for ansible-galaxy problems in execution …
brookelew 44cac5b
Fix syntax error
brookelew 45d709d
Make check_galaxy script use a single test.
brookelew e92cb25
Merge branch 'ansible:devel' into devel
brookelew 78d6a55
Trial check_galaxy integration test
brookelew 1a5bf0a
Finalize check_galaxy integration test
brookelew b79ed6d
Fix wrong name for copied file
brookelew ebba710
Implement requested changes from review
brookelew 3aed183
Fix lint warning and modify bad-ansible.cfg to give a parse error
brookelew e76c0ec
Actual parse error from bad ansible.cfg
brookelew File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,25 @@ | ||
version: 3 | ||
|
||
images: | ||
base_image: | ||
name: quay.io/centos/centos:stream9 | ||
|
||
dependencies: | ||
ansible_core: | ||
package_pip: ansible-core | ||
ansible_runner: | ||
package_pip: ansible-runner | ||
galaxy: | ||
collections: | ||
- containers.podman | ||
|
||
options: | ||
package_manager_path: '/bin/true' | ||
|
||
additional_build_files: | ||
- src: ./files/bad_ansible.cfg | ||
dest: configs | ||
|
||
additional_build_steps: | ||
prepend_galaxy: | ||
- COPY _build/configs/bad_ansible.cfg /etc/ansible/ansible.cfg |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
# Bad ansible.cfg | ||
[defaults] | ||
==?k,sm../a |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In addition to this
assert
, we should add another that checks for the actual error emitted fromansible-galaxy
(visible in the output thanks to using-v3
) to make sure it is the faultyansible.cfg
causing the error and not something else. In this case, looks like the error string we want begins with:There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for getting the exact line I needed!