Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix find roles inside collection repository #297

Merged
merged 5 commits into from
Jul 20, 2023
Merged

Fix find roles inside collection repository #297

merged 5 commits into from
Jul 20, 2023

Conversation

audgirka
Copy link
Contributor

@audgirka audgirka commented Jul 13, 2023 •
edited
Loading

fixes: #2487

@github-actions github-actions bot added the bug Something isn't working label Jul 13, 2023
@audgirka audgirka marked this pull request as ready for review July 18, 2023 12:35
@audgirka audgirka requested a review from a team as a code owner July 18, 2023 12:35
@audgirka audgirka merged commit 9cabbc8 into main Jul 20, 2023
@audgirka audgirka deleted the fix/find_roles branch July 20, 2023 10:33
audgirka added a commit that referenced this pull request Aug 9, 2023
@audgirka
Revert "Fix find roles inside collection repository (#297)"
30bb35c 
This reverts commit 9cabbc8.
@audgirka audgirka mentioned this pull request Aug 9, 2023
Merged
audgirka added a commit that referenced this pull request Aug 9, 2023
@audgirka
Revert "Fix find roles inside collection repository (#297)" (#307)
83ba288 
This reverts commit 9cabbc8.
ssbarnea added a commit that referenced this pull request Aug 10, 2023
@ssbarnea
Revert "Revert "Fix find roles inside collection repository (#297)" (#…
f6d1c89 
…307)"

This reverts commit 83ba288.
ssbarnea added a commit that referenced this pull request Aug 10, 2023
@ssbarnea
Revert "Revert "Fix find roles inside collection repository (#297)" (#…
0000e20 
…307)" (#309)

This reverts commit 83ba288.
ssbarnea added a commit that referenced this pull request Aug 15, 2023
@ssbarnea
Ignore folders that are not valid namaspeces
77f5d5c 
- Adds tests
- Fixes several regressions introduced by #297
This was referenced Aug 15, 2023
Closed
Merged
ssbarnea added a commit that referenced this pull request Aug 16, 2023
@ssbarnea
Ignore folders that are not valid namaspeces (#310)
01f0448 
- Adds tests
- Fixes several regressions introduced by #297
@dbrennand dbrennand mentioned this pull request Oct 24, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shatakshiiii shatakshiiii shatakshiiii approved these changes

@ssbarnea ssbarnea Awaiting requested review from ssbarnea ssbarnea is a code owner automatically assigned from ansible/devtools

@priyamsahoo priyamsahoo Awaiting requested review from priyamsahoo priyamsahoo is a code owner automatically assigned from ansible/devtools

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ansible-lint cannot find roles inside collection repository when it's not installed
2 participants
@audgirka @shatakshiiii